Skip to content

Commit e9223a6

Browse files
fix for group-delete fix (#3609)
1 parent 3f2a505 commit e9223a6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/user/RoleGroupService.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ func (impl RoleGroupServiceImpl) DeleteRoleGroup(bean *bean.RoleGroup) (bool, er
610610
if err != nil {
611611
impl.logger.Errorw("error in getting all role group role mappings or not found", "err", err)
612612
}
613-
allRolesForGroup, err := impl.roleGroupRepository.GetRolesByGroupCasbinName(model.CasbinName)
613+
allRolesForGroup, err := casbin2.GetRolesForUser(model.CasbinName)
614614
if err != nil {
615615
impl.logger.Errorw("error in getting all roles for groups", "err", err)
616616
}
@@ -644,7 +644,7 @@ func (impl RoleGroupServiceImpl) DeleteRoleGroup(bean *bean.RoleGroup) (bool, er
644644
}
645645

646646
for _, role := range allRolesForGroup {
647-
flag := casbin2.DeleteRoleForUser(model.CasbinName, role.Role)
647+
flag := casbin2.DeleteRoleForUser(model.CasbinName, role)
648648
if flag == false {
649649
impl.logger.Warnw("unable to delete mapping of group and user in casbin", "user", model.CasbinName, "role", role)
650650
return false, err

0 commit comments

Comments
 (0)