fix: added deployment app type support for app create api, separated cron time for helm app status update (#2995)

* wip

* updated spec

Author: kartik-579

api/appbean/AppDetail.go

@@ -109,6 +109,7 @@ type CdPipelineDetails struct {
 	Name                          string                                 `json:"name"` //pipelineName
 	EnvironmentName               string                                 `json:"environmentName" `
 	TriggerType                   pipelineConfig.TriggerType             `json:"triggerType" validate:"required"`
+	DeploymentAppType             string                                 `json:"deploymentAppType"`
 	DeploymentStrategyType        chartRepoRepository.DeploymentStrategy `json:"deploymentType,omitempty"` //
 	DeploymentStrategies          []*DeploymentStrategy                  `json:"deploymentStrategies"`
 	PreStage                      *CdStage                               `json:"preStage"`

api/restHandler/CoreAppRestHandler.go

@@ -1646,6 +1646,7 @@ func (handler CoreAppRestHandlerImpl) createCdPipelines(ctx context.Context, app
 			Namespace:                     envModel.Namespace,
 			AppWorkflowId:                 workflowId,
 			CiPipelineId:                  ciPipelineId,
+			DeploymentAppType:             cdPipeline.DeploymentAppType,
 			DeploymentTemplate:            cdPipeline.DeploymentStrategyType,
 			TriggerType:                   cdPipeline.TriggerType,
 			CdArgoSetup:                   cdPipeline.IsClusterCdActive,

client/cron/CdApplicationStatusUpdateHandler.go

@@ -73,7 +73,7 @@ func NewCdApplicationStatusUpdateHandlerImpl(logger *zap.SugaredLogger, appServi
 		logger.Errorw("error on subscribe", "err", err)
 		return nil
 	}
-	_, err = cron.AddFunc(AppStatusConfig.CdPipelineStatusCronTime, impl.HelmApplicationStatusUpdate)
+	_, err = cron.AddFunc(AppStatusConfig.CdHelmPipelineStatusCronTime, impl.HelmApplicationStatusUpdate)
 	if err != nil {
 		logger.Errorw("error in starting helm application status update cron job", "err", err)
 		return nil

pkg/app/AppService.go

@@ -84,6 +84,7 @@ import (
 
 type AppStatusConfig struct {
 	CdPipelineStatusCronTime            string `env:"CD_PIPELINE_STATUS_CRON_TIME" envDefault:"*/2 * * * *"`
+	CdHelmPipelineStatusCronTime        string `env:"CD_HELM_PIPELINE_STATUS_CRON_TIME" envDefault:"*/2 * * * *"`
 	CdPipelineStatusTimeoutDuration     string `env:"CD_PIPELINE_STATUS_TIMEOUT_DURATION" envDefault:"20"`       //in minutes
 	PipelineDegradedTime                string `env:"PIPELINE_DEGRADED_TIME" envDefault:"10"`                    //in minutes
 	HelmPipelineStatusCheckEligibleTime string `env:"HELM_PIPELINE_STATUS_CHECK_ELIGIBLE_TIME" envDefault:"120"` //in seconds

specs/app_create_api.yaml

@@ -544,6 +544,11 @@ components:
           type: string
         triggerType:
           type: string
+        deploymentAppType:
+          type: string
+          oneOf:
+            - 'argo_cd'
+            - 'helm'
         deploymentType:
           type: string
         deploymentStrategies: