Skip to content

Commit 70d4b61

Browse files
query changes for app/other-env api
1 parent e733f4a commit 70d4b61

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

api/bean/AppView.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ type AppEnvironmentContainer struct {
115115
Active bool `json:"-"`
116116
TeamId int `json:"teamId"`
117117
TeamName string `json:"teamName"`
118+
Description string `json:"description" validate:"max=40"`
118119
}
119120

120121
type DeploymentDetailContainer struct {
@@ -150,6 +151,7 @@ type DeploymentDetailContainer struct {
150151
DockerRegistryId string `json:"dockerRegistryId,omitempty"`
151152
IpsAccessProvided bool `json:"ipsAccessProvided"`
152153
DeploymentAppDeleteRequest bool `json:"deploymentAppDeleteRequest"`
154+
Description string `json:"description" validate:"max=40"`
153155
}
154156

155157
type AppDetailContainer struct {
@@ -174,6 +176,7 @@ type Environment struct {
174176
ChartRefId int `json:"chartRefId"`
175177
LastDeployed string `json:"lastDeployed"`
176178
DeploymentAppDeleteRequest bool `json:"deploymentAppDeleteRequest"`
179+
Description string `json:"description" validate:"max=40"`
177180
}
178181

179182
type InstanceDetail struct {

internal/sql/repository/AppListingRepository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ func (impl AppListingRepositoryImpl) FetchOtherEnvironment(appId int) ([]*bean.E
494494
var otherEnvironments []*bean.Environment
495495
query := "select OE.*,B.status as app_status " +
496496
"FROM " +
497-
"(SELECT p.environment_id,env.environment_name, p.last_deployed, env_app_m.app_metrics, env.default as prod, env_app_m.infra_metrics, p.deployment_app_delete_request from ( SELECT pl.id,pl.app_id,pl.environment_id,pl.deleted, pl.deployment_app_delete_request,MAX(pco.created_on) as last_deployed from pipeline pl LEFT JOIN pipeline_config_override pco on pco.pipeline_id = pl.id WHERE pl.app_id = ? and pl.deleted = FALSE GROUP BY pl.id) p INNER JOIN environment env on env.id=p.environment_id LEFT JOIN env_level_app_metrics env_app_m on env.id=env_app_m.env_id and p.app_id = env_app_m.app_id where p.app_id=? and p.deleted = FALSE AND env.active = TRUE GROUP BY 1,2,3,4,5,6,7) OE " +
497+
"(SELECT p.environment_id,env.environment_name,env.description, p.last_deployed, env_app_m.app_metrics, env.default as prod, env_app_m.infra_metrics, p.deployment_app_delete_request from ( SELECT pl.id,pl.app_id,pl.environment_id,pl.deleted, pl.deployment_app_delete_request,MAX(pco.created_on) as last_deployed from pipeline pl LEFT JOIN pipeline_config_override pco on pco.pipeline_id = pl.id WHERE pl.app_id = ? and pl.deleted = FALSE GROUP BY pl.id) p INNER JOIN environment env on env.id=p.environment_id LEFT JOIN env_level_app_metrics env_app_m on env.id=env_app_m.env_id and p.app_id = env_app_m.app_id where p.app_id=? and p.deleted = FALSE AND env.active = TRUE GROUP BY 1,2,3,4,5,6,7,8) OE " +
498498
" LEFT JOIN app_status B ON OE.environment_id = B.env_id AND B.app_id = ? ;"
499499
impl.Logger.Debugw("other env query:", query)
500500
_, err := impl.dbConnection.Query(&otherEnvironments, query, appId, appId, appId)

pkg/pipeline/PropertiesConfig.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ type EnvironmentProperties struct {
5555
IsOverride bool `sql:"isOverride"`
5656
IsBasicViewLocked bool `json:"isBasicViewLocked"`
5757
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor"` //default "UNDEFINED" in db
58+
Description string `json:"description" validate:"max=40"`
5859
}
5960

6061
type EnvironmentPropertiesResponse struct {
@@ -159,6 +160,7 @@ func (impl PropertiesConfigServiceImpl) GetEnvironmentProperties(appId, environm
159160
ManualReviewed: envOverride.ManualReviewed,
160161
Active: envOverride.Active,
161162
Namespace: env.Namespace,
163+
Description: env.Description,
162164
EnvironmentId: environmentId,
163165
EnvironmentName: env.Name,
164166
Latest: envOverride.Latest,

0 commit comments

Comments
 (0)