Skip to content

Commit 58a7898

Browse files
added missing audit logs while deleting cd pipeline (#3822)
1 parent 172deb8 commit 58a7898

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pkg/pipeline/PipelineBuilder.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1988,7 +1988,7 @@ func (impl *PipelineBuilderImpl) PatchCdPipelines(cdPipelines *bean.CDPatchReque
19881988
impl.logger.Errorw("error in getting cd pipeline by id", "err", err, "id", cdPipelines.Pipeline.Id)
19891989
return pipelineRequest, err
19901990
}
1991-
deleteResponse, err := impl.DeleteCdPipelinePartial(pipeline, ctx, deleteAction)
1991+
deleteResponse, err := impl.DeleteCdPipelinePartial(pipeline, ctx, deleteAction, cdPipelines.UserId)
19921992
pipelineRequest.AppDeleteResponse = deleteResponse
19931993
return pipelineRequest, err
19941994
default:
@@ -2102,6 +2102,8 @@ func (impl *PipelineBuilderImpl) DeleteCdPipeline(pipeline *pipelineConfig.Pipel
21022102
}
21032103
}
21042104
}
2105+
appWorkflowMapping.UpdatedBy = userId
2106+
appWorkflowMapping.UpdatedOn = time.Now()
21052107
err = impl.appWorkflowRepository.DeleteAppWorkflowMapping(appWorkflowMapping, tx)
21062108
if err != nil {
21072109
impl.logger.Errorw("error in deleting workflow mapping", "err", err)
@@ -2211,7 +2213,7 @@ func (impl *PipelineBuilderImpl) DeleteCdPipeline(pipeline *pipelineConfig.Pipel
22112213
return deleteResponse, nil
22122214
}
22132215

2214-
func (impl *PipelineBuilderImpl) DeleteCdPipelinePartial(pipeline *pipelineConfig.Pipeline, ctx context.Context, deleteAction int) (*bean.AppDeleteResponseDTO, error) {
2216+
func (impl *PipelineBuilderImpl) DeleteCdPipelinePartial(pipeline *pipelineConfig.Pipeline, ctx context.Context, deleteAction int, userId int32) (*bean.AppDeleteResponseDTO, error) {
22152217
cascadeDelete := true
22162218
forceDelete := false
22172219
deleteResponse := &bean.AppDeleteResponseDTO{
@@ -2301,6 +2303,8 @@ func (impl *PipelineBuilderImpl) DeleteCdPipelinePartial(pipeline *pipelineConfi
23012303
}
23022304
impl.logger.Infow("app deleted from argocd", "id", pipeline.Id, "pipelineName", pipeline.Name, "app", deploymentAppName)
23032305
pipeline.DeploymentAppDeleteRequest = true
2306+
pipeline.UpdatedOn = time.Now()
2307+
pipeline.UpdatedBy = userId
23042308
err = impl.pipelineRepository.Update(pipeline, tx)
23052309
if err != nil {
23062310
impl.logger.Errorw("error in partially delete cd pipeline", "err", err)

0 commit comments

Comments
 (0)