Skip to content

Commit 56dac78

Browse files
helm install error, nil pointer fix (#3310)
1 parent a1e809a commit 56dac78

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/app/AppService.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,13 +2189,13 @@ func (impl *AppServiceImpl) createHelmAppForCdPipeline(overrideRequest *bean.Val
21892189
impl.logger.Errorw("release not found, failed to re-install helm application", "err", err)
21902190
return false, err
21912191
}
2192-
}
2193-
2194-
if err != nil {
2192+
} else if err != nil {
21952193
impl.logger.Errorw("error in updating helm application for cd pipeline", "err", err)
21962194
return false, err
2195+
} else {
2196+
impl.logger.Debugw("updated helm application", "response", updateApplicationResponse, "isSuccess", updateApplicationResponse.Success)
21972197
}
2198-
impl.logger.Debugw("updated helm application", "response", updateApplicationResponse, "isSuccess", updateApplicationResponse.Success)
2198+
21992199
} else {
22002200

22012201
helmResponse, err := impl.helmInstallReleaseWithCustomChart(ctx, releaseIdentifier, referenceChartByte, mergeAndSave)

0 commit comments

Comments
 (0)