handled nil pointer in imagePullSecret service when asserting k8s error type (#3208) (#106)

kartik-579 · web-flow · commit 4c0e00c0fdec · 2023-03-29T15:47:50.000+05:30
diff --git a/pkg/dockerRegistry/DockerRegistryIpsConfigService.go b/pkg/dockerRegistry/DockerRegistryIpsConfigService.go
@@ -234,8 +234,8 @@ func (impl DockerRegistryIpsConfigServiceImpl) createOrUpdateDockerRegistryImage
 	}
 	secret, err := impl.k8sUtil.GetSecret(namespace, ipsName, k8sClient)
 	if err != nil {
-		statusError, _ := err.(*k8sErrors.StatusError)
-		if statusError.Status().Code != http.StatusNotFound {
+		statusError, ok := err.(*k8sErrors.StatusError)
+		if !ok || (statusError != nil && statusError.Status().Code != http.StatusNotFound) {
 			impl.logger.Errorw("error in getting secret", "clusterId", clusterId, "namespace", namespace, "ipsName", ipsName, "error", err)
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -234,8 +234,8 @@ func (impl DockerRegistryIpsConfigServiceImpl) createOrUpdateDockerRegistryImage`
`234`	`234`	`}`
`235`	`235`	`secret, err := impl.k8sUtil.GetSecret(namespace, ipsName, k8sClient)`
`236`	`236`	`if err != nil {`
`237`		`- statusError, _ := err.(*k8sErrors.StatusError)`
`238`		`- if statusError.Status().Code != http.StatusNotFound {`
	`237`	`+ statusError, ok := err.(*k8sErrors.StatusError)`
	`238`	`+ if !ok \|\| (statusError != nil && statusError.Status().Code != http.StatusNotFound) {`
`239`	`239`	`impl.logger.Errorw("error in getting secret", "clusterId", clusterId, "namespace", namespace, "ipsName", ipsName, "error", err)`
`240`	`240`	`return err`
`241`	`241`	`}`