Skip to content

Commit 446612b

Browse files
authored
updated log type for pipeline status methods (#2926)
1 parent da8b5d4 commit 446612b

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

api/router/pubsub/ApplicationStatusUpdateHandler.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ type ApplicationDetail struct {
6666

6767
func (impl *ApplicationStatusUpdateHandlerImpl) Subscribe() error {
6868
callback := func(msg *pubsub.PubSubMsg) {
69-
impl.logger.Debug("received app update request")
70-
//defer msg.Ack()
7169
impl.logger.Debugw("APP_STATUS_UPDATE_REQ", "stage", "raw", "data", msg.Data)
7270
applicationDetail := ApplicationDetail{}
7371
err := json.Unmarshal([]byte(msg.Data), &applicationDetail)

client/cron/CdApplicationStatusUpdateHandler.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ func NewCdApplicationStatusUpdateHandlerImpl(logger *zap.SugaredLogger, appServi
9393

9494
func (impl *CdApplicationStatusUpdateHandlerImpl) Subscribe() error {
9595
callback := func(msg *pubsub.PubSubMsg) {
96-
impl.logger.Debug("received argo pipeline status update request")
97-
//defer msg.Ack()
9896
statusUpdateEvent := pipeline.ArgoPipelineStatusSyncEvent{}
9997
err := json.Unmarshal([]byte(string(msg.Data)), &statusUpdateEvent)
10098
if err != nil {

pkg/app/AppService.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ func (impl *AppServiceImpl) UpdateDeploymentStatusForPipeline(app *v1alpha1.Appl
495495
}
496496

497497
func (impl *AppServiceImpl) UpdatePipelineStatusTimelineForApplicationChanges(app *v1alpha1.Application, cdWfrId int, statusTime time.Time, triggeredAt time.Time, statusTimeoutDuration int, latestTimelineBeforeUpdate *pipelineConfig.PipelineStatusTimeline) (bool, bool, error) {
498-
impl.logger.Infow("updating pipeline status timeline", "app", app, "pipelineOverride", cdWfrId, "APP_TO_UPDATE", app.Name)
498+
impl.logger.Debugw("updating pipeline status timeline", "app", app, "pipelineOverride", cdWfrId, "APP_TO_UPDATE", app.Name)
499499
isTimelineUpdated := false
500500
isTimelineTimedOut := false
501501
terminalStatusExists, err := impl.pipelineStatusTimelineRepository.CheckIfTerminalStatusTimelinePresentByWfrId(cdWfrId)

pkg/pipeline/CdHandler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ func (impl *CdHandlerImpl) UpdatePipelineTimelineAndStatusByLiveApplicationFetch
208208
impl.Logger.Errorw("error in getting latest cdWfr by cdPipelineId", "err", err, "pipelineId", pipeline.Id)
209209
return nil, isTimelineUpdated
210210
}
211-
impl.Logger.Infow("ARGO_PIPELINE_STATUS_UPDATE_REQ", "stage", "checkingDeploymentStatus", "argoAppName", pipeline, "cdWfr", cdWfr)
211+
impl.Logger.Debugw("ARGO_PIPELINE_STATUS_UPDATE_REQ", "stage", "checkingDeploymentStatus", "argoAppName", pipeline, "cdWfr", cdWfr)
212212
if util3.IsTerminalStatus(cdWfr.Status) {
213213
//drop event
214214
return nil, isTimelineUpdated
@@ -267,7 +267,7 @@ func (impl *CdHandlerImpl) UpdatePipelineTimelineAndStatusByLiveApplicationFetch
267267
err = impl.appStatusService.UpdateStatusWithAppIdEnvId(pipeline.AppId, pipeline.EnvironmentId, string(appStatus))
268268
if err != nil {
269269
impl.Logger.Errorw("error occurred while updating app-status", "err", err, "appId", pipeline.AppId, "envId", pipeline.EnvironmentId)
270-
impl.Logger.Infow("ignoring the error", "err", err, "appId", pipeline.AppId, "envId", pipeline.EnvironmentId)
270+
impl.Logger.Debugw("ignoring the error, UpdateStatusWithAppIdEnvId", "err", err, "appId", pipeline.AppId, "envId", pipeline.EnvironmentId)
271271
}
272272
}
273273
if isSucceeded {

0 commit comments

Comments
 (0)