wip (#2704)

vikramdevtron · web-flow · commit 40664ff097b3 · 2022-11-30T11:49:03.000+05:30
diff --git a/pkg/appClone/AppCloneService.go b/pkg/appClone/AppCloneService.go
@@ -20,7 +20,6 @@ package appClone
 import (
 	"context"
 	bean2 "github.com/devtron-labs/devtron/api/bean"
-	"github.com/devtron-labs/devtron/internal/util"
 	"github.com/devtron-labs/devtron/pkg/chart"
 	"strings"
 
@@ -597,8 +596,8 @@ func (impl *AppCloneServiceImpl) createWfMappings(refWfMappings []appWorkflow.Ap
 		}
 	}
 	if len(webhookMappings) > 0 {
-		err := &util.ApiError{Code: "501", HttpStatusCode: 501, UserMessage: "ref app has external ci configured, app clone does not supported this"}
-		return err
+		impl.logger.Warn("external ci webhook found in workflow, not supported for clone")
+		return nil
 	}
 	if len(ciMapping) == 0 {
 		impl.logger.Warn("no ci pipeline found")

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ package appClone`
`20`	`20`	`import (`
`21`	`21`	`"context"`
`22`	`22`	`bean2 "github.com/devtron-labs/devtron/api/bean"`
`23`		`- "github.com/devtron-labs/devtron/internal/util"`
`24`	`23`	`"github.com/devtron-labs/devtron/pkg/chart"`
`25`	`24`	`"strings"`
`26`	`25`
`@@ -597,8 +596,8 @@ func (impl *AppCloneServiceImpl) createWfMappings(refWfMappings []appWorkflow.Ap`
`597`	`596`	`}`
`598`	`597`	`}`
`599`	`598`	`if len(webhookMappings) > 0 {`
`600`		`- err := &util.ApiError{Code: "501", HttpStatusCode: 501, UserMessage: "ref app has external ci configured, app clone does not supported this"}`
`601`		`- return err`
	`599`	`+ impl.logger.Warn("external ci webhook found in workflow, not supported for clone")`
	`600`	`+ return nil`
`602`	`601`	`}`
`603`	`602`	`if len(ciMapping) == 0 {`
`604`	`603`	`impl.logger.Warn("no ci pipeline found")`