Skip to content

Conversation

@ooliver1
Copy link

@ooliver1 ooliver1 commented Oct 7, 2021

New icon section

closes #809

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date


This PR adds/fixes

a white apple svg

Notes

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Oct 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/apple/apple-white.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, there's no white version. In this case, how should we name the file? @amacado, @Thomas-Boi.

@Thomas-Boi
Copy link
Member

Hi @ooliver1,

While we appreciate your work, I don't think this PR is the right thing for the repo.

Our icon-making process will strip an of its colors, making all icons by default black. Then, we add colors to them using CSS styles. However, the user can override our default colors however they wish since CSS allows for it.

As for storing a white version of the SVG, I don't think it'll provide anything new to the repo. Anyone can download the file and change the fill of the SVG to any colors that they want. Storing multiple versions of basically the same icon is unnecessary.

I'll be open to any other input. Until then, I'll close this PR.

@Thomas-Boi Thomas-Boi closed this Oct 8, 2021
@ooliver1
Copy link
Author

ooliver1 commented Oct 8, 2021

Well it was an issue so I made a pr for it lmao

@ooliver1 ooliver1 deleted the apple-white branch October 8, 2021 17:10
@Thomas-Boi
Copy link
Member

You are correct. I'll close that issue as soon as possible. I apologize for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon request: Apple [White]

3 participants