Skip to content

Commit b490d7b

Browse files
committed
implement suggest changes from PR reviews
1 parent 660781a commit b490d7b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/PULL_REQUEST_TEMPLATE/new_icon.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
- [ ] PR's base is the `develop` branch.
77
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
88
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
9-
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
9+
- [ ] A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
1010

1111
<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
1212

.github/workflows/post_peek_screenshot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jobs:
109109
1. The number of Glyphs matches the number of SVGs that were selected.
110110
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
111111
3. The icons are of high quality (legible, matches the official logo, etc.)
112-
4. Your addition to the `devicon.json` file is alphabetically ordered
112+
4. A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
113113
114114
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this [doc](https://icomoon.io/#faq/importing) for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
115115

0 commit comments

Comments
 (0)