Skip to content

Commit 8790491

Browse files
Change from single quotes to escaped double quotes
Apply suggestions from code review. Thanks @lunatic-fox Co-authored-by: Josélio Júnior <[email protected]>
1 parent c808948 commit 8790491

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/scripts/check_icon_pr.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,20 +65,20 @@ def check_devicon_object(icon: dict):
6565

6666
try:
6767
if type(icon["name"]) != str:
68-
err_msgs.append("- 'name' must be a string")
68+
err_msgs.append("- Property \"name\" value must be type string.")
6969
except KeyError:
70-
err_msgs.append("- missing key: 'name'.")
70+
err_msgs.append("- Missing property key: \"name\".")
7171

7272
try:
7373
for altname in icon["altnames"]:
7474
if type(altname) != str:
7575
raise TypeError()
7676
if altname == icon["name"]:
77-
err_msgs.append(f"- 'altnames' should not contain the same name as 'name'. please remove {altname} from 'altnames'")
77+
err_msgs.append(f"- \"altnames\" should not contain the same name as \"name\" property. Please remove \"{altname}\" from \"altnames\"")
7878
except TypeError:
79-
err_msgs.append("- 'altnames' must be an array of strings, not: " + str(icon["altnames"]))
79+
err_msgs.append("- \"altnames\" must be an array of strings, not: " + str(icon["altnames"]))
8080
except KeyError:
81-
err_msgs.append("- missing key: 'altnames'.")
81+
err_msgs.append("- Missing property key: \"altnames\".")
8282

8383
try:
8484
for tag in icon["tags"]:
@@ -123,7 +123,7 @@ def check_devicon_object(icon: dict):
123123

124124
try:
125125
if type(icon["aliases"]) != list:
126-
err_msgs.append("- 'aliases' must be an array of objects.")
126+
err_msgs.append("- \"aliases\" must be an array of objects.")
127127
except KeyError:
128128
err_msgs.append("- missing key: 'aliases'.")
129129

0 commit comments

Comments
 (0)