Skip to content

Commit 300685a

Browse files
authored
Add alphabetical ordering of devicon.json to PR checklist (#1332)
* Add note to maintainers about checking devicon.json related #1327 * implement suggest changes from PR reviews * fix updating devicon.json wiki link
1 parent eb35d73 commit 300685a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/PULL_REQUEST_TEMPLATE/new_icon.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
- [ ] PR's base is the `develop` branch.
77
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/wiki/Organizing-SVGs)
88
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/wiki/SVG-Standards)
9-
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60)
9+
- [ ] A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60)
1010

1111
<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
1212

.github/workflows/post_peek_screenshot.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ jobs:
109109
1. The number of Glyphs matches the number of SVGs that were selected.
110110
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
111111
3. The icons are of high quality (legible, matches the official logo, etc.)
112+
4. A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60)
112113
113114
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this [doc](https://icomoon.io/#faq/importing) for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
114115
@@ -151,7 +152,7 @@ jobs:
151152
Make sure that:
152153
153154
- Your SVGs are named and added correctly to the /icons folder as seen [here](https://github.com/devicons/devicon/wiki/Organizing-SVGs).
154-
- Your icon information has been added to the `devicon.json` as seen [here](https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60)
155+
- Your icon information has been added to the `devicon.json` as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60)
155156
- Your PR title follows the format seen [here](https://github.com/devicons/devicon/wiki/Overview-on-Submitting-Icons)
156157
157158
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

0 commit comments

Comments
 (0)