fix: paste from clipboard doesn't work on desktop #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (add) added a condition to the check for inputType number.
Contributor
|
This has been fixed with #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(add) added a condition to the check for inputType number.
What does this PR do?
Paste from clipboard returned to work if inputType number on desktop.
Any background context you want to provide?
When the
handleKeyDownfunction checks for keys pressed from the keyboard, the condition for inputType number validated the values, and ControlLeft and V returned false when validated in theisInputValueValidfunction, which combined with the negation of the boolean triggeredevent.preventDefault, and thehandlePastefunction was not even called. I added a condition that ignored the last V and Insert, which does not block further execution of the event, and thehandlePastemethod is called correctly when Ctrl + V and Shift + Insert are combined. I suspect that my solution might not look elegant enough, but combined with the checks elsewhere, V and Insert can't get into Input in this case.