Skip to content

Commit 1600034

Browse files
authored
fix(DFP-1113): fix excessive number of pending callbacks (#437)
## Description Closes: #418 https://forbole.atlassian.net/browse/DFP-1113 This PR fixes appearance of the `Excessive number of pending callbacks` warning by updating react-naitve to `0.71.4`. The cause of the issue was due to an improper if check, which result in a constant re-render, thus triggering the warning to appear. Additional information on this error can be found [here](facebook/react-native#35387): --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed
1 parent 1c6b149 commit 1600034

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

.node-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"react": "18.2.0",
6969
"react-content-loader": "^6.2.0",
7070
"react-i18next": "^11.17.2",
71-
"react-native": "0.71.1",
71+
"react-native": "0.71.4",
7272
"react-native-aes-crypto": "^2.1.1",
7373
"react-native-animated-pagination-dots": "^0.1.73",
7474
"react-native-ble-plx": "^2.0.3",
@@ -113,7 +113,7 @@
113113
"@babel/core": "^7.20.0",
114114
"@babel/preset-env": "^7.20.0",
115115
"@babel/runtime": "^7.20.0",
116-
"@react-native-community/eslint-config": "^3.0.0",
116+
"@react-native-community/eslint-config": "^3.2.0",
117117
"@storybook/addon-actions": "^6.5.16",
118118
"@storybook/addon-knobs": "^6.4.0",
119119
"@storybook/addon-links": "^6.5.16",
@@ -153,7 +153,7 @@
153153
"husky": ">=6",
154154
"jest": "^29.2.1",
155155
"lint-staged": ">=10",
156-
"metro-react-native-babel-preset": "0.73.7",
156+
"metro-react-native-babel-preset": "0.73.8",
157157
"prettier": "^2.4.1",
158158
"react-dom": "18.0.0",
159159
"react-native-flipper-performance-plugin": "^0.3.1",

0 commit comments

Comments
 (0)