Remove getUrl() method - let applications handle URL generation

Applications can easily generate URLs using Router::url() directly
in their serving controller context where routing is properly configured.
This reduces unnecessary abstraction and removes the assumption about
routing structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: dereuromark

docs/Documentation/FileServing.md

@@ -98,15 +98,15 @@ class ImagesController extends AppController
 ### 3. Generate URLs in Templates
 
 ```php
-// Use the URL helper
-$fileStorageTable = $this->fetchTable('FileStorage.FileStorage');
+// Generate URL to your serving controller
+use Cake\Routing\Router;
 
 echo $this->Html->link('View File',
-    $fileStorageTable->getUrl($fileStorage)
+    Router::url(['controller' => 'Files', 'action' => 'serve', $fileStorage->id])
 );
 
-// This generates URL to your configured route:
-// /images/display/{id}
+// This generates URL to your serving route:
+// /files/serve/{id}
 ```
 
 ---
@@ -315,8 +315,11 @@ public function share($fileStorageId)
         'expires' => strtotime('+24 hours'),
     ]);
 
-    // Generate full URL
-    $url = $fileStorageTable->getUrl($fileStorage, [
+    // Generate full URL with signature
+    $url = Router::url([
+        'controller' => 'Files',
+        'action' => 'serve',
+        $fileStorage->id,
         '?' => $signatureData,
         '_full' => true,
     ]);

src/Model/Table/FileStorageTable.php

@@ -4,7 +4,6 @@
 
 use Cake\Core\Configure;
 use Cake\ORM\Table;
-use Cake\Routing\Router;
 
 /**
  * FileStorageTable
@@ -67,47 +66,4 @@ public function initialize(array $config): void
             (array)Configure::read('FileStorage.behaviorConfig'),
         );
     }
-
-    /**
-     * Generate URL to file serving endpoint
-     *
-     * Applications must implement their own serving controller.
-     * This method generates the URL to your controller's action.
-     *
-     * Configure the route in config/app.php:
-     * ```
-     * 'FileStorage' => [
-     *     'serveRoute' => [
-     *         'controller' => 'Files',
-     *         'action' => 'serve',
-     *         'plugin' => false,
-     *     ],
-     * ],
-     * ```
-     *
-     * @param \FileStorage\Model\Entity\FileStorage $entity File storage entity
-     * @param array<string, mixed> $options URL options (passed to Router::url)
-     *
-     * @return string URL to file
-     */
-    public function getUrl($entity, array $options = []): string
-    {
-        $route = Configure::read('FileStorage.serveRoute', [
-            'controller' => 'Files',
-            'action' => 'serve',
-            'plugin' => false,
-        ]);
-
-        $url = array_merge($route, [$entity->id]);
-
-        // Merge in query parameters
-        if (isset($options['?'])) {
-            $url['?'] = $options['?'];
-        }
-
-        // Check if full URL is requested
-        $full = $options['_full'] ?? false;
-
-        return Router::url($url, $full);
-    }
 }

tests/TestCase/Model/Table/FileStorageTableTest.php

@@ -86,31 +86,4 @@ public function testFileSavingArray()
 
         $this->FileStorage->saveOrFail($entity);
     }
-
-    /**
-     * Test getUrl method exists and returns string
-     *
-     * Note: Full URL generation testing requires routing to be configured,
-     * which is better tested in integration tests.
-     *
-     * @return void
-     */
-    public function testGetUrlMethodExists(): void
-    {
-        $fileStorage = $this->FileStorage->newEntity([
-            'id' => 'test-uuid-123',
-            'filename' => 'test.jpg',
-        ]);
-
-        $this->assertTrue(method_exists($this->FileStorage, 'getUrl'));
-
-        // Verify it accepts the expected parameters
-        $reflection = new \ReflectionMethod($this->FileStorage, 'getUrl');
-        $this->assertEquals(2, $reflection->getNumberOfParameters());
-
-        $params = $reflection->getParameters();
-        $this->assertEquals('entity', $params[0]->getName());
-        $this->assertEquals('options', $params[1]->getName());
-        $this->assertTrue($params[1]->isDefaultValueAvailable());
-    }
 }