Commit 26c4892
authored
ci: fix isolated-env test (#4883)
This test in firefox started to fail all of a sudden, and [almost
consistently](#4881). I
couldn't figure out why the test kept failing, so after playing around
with the order of operations I figured out that the iframe is loading
axe and calling the `axe-loaded` event [_before_ mocha runs the
`before`](https://app.circleci.com/pipelines/github/dequelabs/axe-core/7369/workflows/8fa125f3-2a32-43d9-8ec9-d5a9ccd172df/jobs/79258?invite=true#step-109-11841_78)
where we look for the event. So to fix it I changed up the loading order
so the script runs first and adds the event tracking, and now the event
tracking now happens outside the `before` function and keeps track of
the logs. Then inside the `before` we see if the message has already
been fired, otherwise we listen to the event as we were doing before.1 parent 828e96c commit 26c4892
File tree
2 files changed
+17
-7
lines changed- test/integration/full/isolated-env
2 files changed
+17
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
119 | 122 | | |
120 | 123 | | |
121 | 124 | | |
| |||
130 | 133 | | |
131 | 134 | | |
132 | 135 | | |
133 | | - | |
134 | | - | |
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
2 | 6 | | |
3 | 7 | | |
4 | 8 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
48 | 57 | | |
49 | 58 | | |
50 | 59 | | |
| |||
0 commit comments