Skip to content

Modify call to javac to put options in temp file instead of on command line to prevent problems with command line being too long #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify call to javac to put options in temp file instead of on command line to prevent problems with command line being too long #4990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ale_linters/java/javac.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,23 @@ function! ale_linters#java#javac#GetCommand(buffer, import_paths, meta) abort
" Create .class files in a temporary directory, which we will delete later.
let l:class_file_directory = ale#command#CreateDirectory(a:buffer)

" Always run javac from the directory the file is in, so we can resolve
" relative paths correctly.
return '%e -Xlint'
\ . ale#Pad(l:cp_option)
\ . ale#Pad(l:sp_option)
\ . ' -d ' . ale#Escape(l:class_file_directory)
\ . ale#Pad(ale#Var(a:buffer, 'java_javac_options'))
\ . ' %t'
"=======================================================
" Write file options to a tempfile to bypass long
" command line issues
"=======================================================

" Switch backslashes in Windows filenames to forward slashes
let l:adjusted_cp_option = substitute( l:cp_option, "\\", "/", "g")
let l:adjusted_sp_option = substitute( l:sp_option, "\\", "/", "g")
let l:adjusted_class_file_directory = substitute( l:class_file_directory, "\\", "/", "g")
call writefile( [
\ ale#Pad(l:adjusted_cp_option),
\ ale#Pad(l:adjusted_sp_option),
\ ' -d ' . ale#Escape(l:adjusted_class_file_directory),
\ ale#Pad(ale#Var(a:buffer, 'java_javac_options')),
\ ], l:class_file_directory . '/javac_options')

return '%e -Xlint' . ' @' . l:class_file_directory . '/javac_options ' . '%t'
endfunction

function! ale_linters#java#javac#Handle(buffer, lines) abort
Expand Down
Loading