-
Notifications
You must be signed in to change notification settings - Fork 2
Add Farcaster icon to navigation menu #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
arredr2
commented
Mar 12, 2025
- Added Farcaster SVG asset
- Updated Header component to include Farcaster in social links
- Link points to DELV's Warpcast channel at https://warpcast.com/~/channel/delv
|
@arredr2 is attempting to deploy a commit to the delv Team on Vercel. A member of the Team first needs to authorize it. |
ryangoree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Just need to update the lock files.
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you ran npm install which added a second lock file. Please delete the package-lock.json and run yarn install to fix the yarn.lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ryangoree! Updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! But, it looks like it used a newer version of yarn which this repo hasn't been migrated to yet. I just locked the yarn version in a new commit to main.
Please rebase onto main then run yarn again to reconcile the yarn.lock changes. If there are any lingering config files from the newer yarn (e.g., .yarn/*), they should be deleted. The only change outside of your new asset and code should be the version updates for the vite patch upgrade.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think that did it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I added .yarn/ to .gitignore to prevent these files from being tracked in the future. Let me know if you'd prefer I revert this change though.
| # Manual changes might be lost - proceed with caution! | ||
|
|
||
| __metadata: | ||
| version: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still the lock file version for the newer version of yarn. The changes to this file should be very minimal, only including the vite version bump + any upgrades to its dependencies.
- Reset this file to it's original state (undo all changes)
- Ensure
yarnv1 is installed (you may need to runnpm install --global yarn) - Run
yarnand ensure the comment at the top of this file still saysyarn lockfile v1
| *.sw? | ||
|
|
||
| .env | ||
| .env.yarn/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be on separate lines to work.
| .env.yarn/ | |
| .env | |
| .yarn/ |