Skip to content

Commit a144752

Browse files
authored
fix: resolve some warnings (#3862)
# Description Right now, it's hard to discern fixable warnings due to the number of deprecated methods and structs we have to facilitate migration to kernel. This PR fixes a few of the currently fixable warnings that slipped through the cracks. --------- Signed-off-by: Robert Pack <[email protected]>
1 parent 278fb2b commit a144752

File tree

4 files changed

+5
-11
lines changed

4 files changed

+5
-11
lines changed

crates/aws/tests/repair_s3_rename_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use deltalake_core::logstore::object_store::{
99
use deltalake_core::{DeltaTableBuilder, ObjectStore, Path};
1010
use deltalake_test::utils::IntegrationContext;
1111
use futures::stream::BoxStream;
12-
use object_store::{MultipartUpload, PutMultipartOpts, PutPayload};
12+
use object_store::{MultipartUpload, PutMultipartOptions, PutPayload};
1313
use serial_test::serial;
1414
use std::ops::Range;
1515
use std::sync::{Arc, Mutex};
@@ -237,7 +237,7 @@ impl ObjectStore for DelayedObjectStore {
237237
async fn put_multipart_opts(
238238
&self,
239239
location: &Path,
240-
options: PutMultipartOpts,
240+
options: PutMultipartOptions,
241241
) -> ObjectStoreResult<Box<dyn MultipartUpload>> {
242242
self.inner.put_multipart_opts(location, options).await
243243
}

crates/catalog-unity/src/datafusion.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use datafusion::catalog::SchemaProvider;
66
use datafusion::catalog::{CatalogProvider, CatalogProviderList};
77
use datafusion::common::DataFusionError;
88
use datafusion::datasource::TableProvider;
9-
use futures::FutureExt;
109
use moka::future::Cache;
1110
use moka::Expiry;
1211
use std::any::Any;

crates/core/src/delta_datafusion/table_provider.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -988,10 +988,7 @@ impl ExecutionPlan for DeltaScan {
988988
parent_filters: Vec<Arc<dyn PhysicalExpr>>,
989989
_config: &ConfigOptions,
990990
) -> Result<FilterDescription> {
991-
Ok(FilterDescription::from_children(
992-
parent_filters,
993-
&self.children(),
994-
)?)
991+
FilterDescription::from_children(parent_filters, &self.children())
995992
}
996993
}
997994

crates/core/tests/read_delta_partitions_test.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
use std::path::PathBuf;
2-
use std::process::Command;
31
use url::Url;
42

53
#[allow(dead_code)]
@@ -48,7 +46,7 @@ async fn read_null_partitions_from_checkpoint() {
4846

4947
// verify that table loads from checkpoint and handles null partitions
5048
let table = deltalake_core::open_table(
51-
url::Url::from_directory_path(std::path::Path::new(&table.table_uri())).unwrap(),
49+
Url::from_directory_path(std::path::Path::new(&table.table_uri())).unwrap(),
5250
)
5351
.await
5452
.unwrap();
@@ -64,7 +62,7 @@ async fn load_from_delta_8_0_table_with_special_partition() {
6462

6563
let path = "../test/tests/data/delta-0.8.0-special-partition";
6664
let table = deltalake_core::open_table(
67-
url::Url::from_directory_path(std::fs::canonicalize(&path).unwrap()).unwrap(),
65+
Url::from_directory_path(std::fs::canonicalize(&path).unwrap()).unwrap(),
6866
)
6967
.await
7068
.unwrap();

0 commit comments

Comments
 (0)