chore: use fixed variable for contract version #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| /// @notice Semantic version. | ||
| /// @custom:semver 1.0.0 | ||
| string public constant version = "1.0.0"; |
There was a problem hiding this comment.
Bug: Version Function Change Breaks Interface Compliance
The version function was converted from a public pure virtual function to a public constant string. This change removes the ability for derived contracts to override the version and alters its state mutability from pure to view, breaking interface compliance (e.g., with ISemver) and potentially affecting external contracts expecting a pure function.
Locations (2)
0xOneTony
approved these changes
Jul 24, 2025
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.