From 7458e0f4b758e7b79291d397cd73c4ccb36f2832 Mon Sep 17 00:00:00 2001 From: 0xchin <77933451+0xChin@users.noreply.github.com> Date: Thu, 24 Jul 2025 10:05:41 -0300 Subject: [PATCH] chore: use fixed variable for contract version --- .../snapshots/abi/ProposalValidator.json | 2 +- packages/contracts-bedrock/snapshots/semver-lock.json | 4 ++-- .../src/governance/ProposalValidator.sol | 10 ++++------ 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/contracts-bedrock/snapshots/abi/ProposalValidator.json b/packages/contracts-bedrock/snapshots/abi/ProposalValidator.json index dc516cfa49b44..c1f63a7b24dca 100644 --- a/packages/contracts-bedrock/snapshots/abi/ProposalValidator.json +++ b/packages/contracts-bedrock/snapshots/abi/ProposalValidator.json @@ -538,7 +538,7 @@ "type": "string" } ], - "stateMutability": "pure", + "stateMutability": "view", "type": "function" }, { diff --git a/packages/contracts-bedrock/snapshots/semver-lock.json b/packages/contracts-bedrock/snapshots/semver-lock.json index 3a11df4c0a069..215f92c69a8a4 100644 --- a/packages/contracts-bedrock/snapshots/semver-lock.json +++ b/packages/contracts-bedrock/snapshots/semver-lock.json @@ -176,8 +176,8 @@ "sourceCodeHash": "0x18f43b227decd0f2a895b8b55e23fa6a47706697c272bbf2482b3f912be446e1" }, "src/governance/ProposalValidator.sol:ProposalValidator": { - "initCodeHash": "0x6bcced3e1050048ecc63fd4d9a86ec72e756de4cb328d29c357cc31c87834341", - "sourceCodeHash": "0x9380a09eeb5f12304baf0d45ea14e7bbd1b046d805429bfe0de970a7dfccd176" + "initCodeHash": "0x8f58c80a20e9f5e631d9451d86b2b5478a60879e58420f6788e75629f5863430", + "sourceCodeHash": "0x1d4ce0d6f868bd36418e7e760c81ecb033c15720e6a35f088ea135620fcae91a" }, "src/legacy/DeployerWhitelist.sol:DeployerWhitelist": { "initCodeHash": "0x53099379ed48b87f027d55712dbdd1da7d7099925426eb0531da9c0012e02c29", diff --git a/packages/contracts-bedrock/src/governance/ProposalValidator.sol b/packages/contracts-bedrock/src/governance/ProposalValidator.sol index 30702c95efa85..19500f835f048 100644 --- a/packages/contracts-bedrock/src/governance/ProposalValidator.sol +++ b/packages/contracts-bedrock/src/governance/ProposalValidator.sol @@ -206,6 +206,10 @@ contract ProposalValidator is OwnableUpgradeable, ReinitializableBase, ISemver { CONSTANTS //////////////////////////////////////////////////////////////*/ + /// @notice Semantic version. + /// @custom:semver 1.0.0 + string public constant version = "1.0.0"; + /// @notice The divisor used for percentage calculations in optimistic voting modules. /// @dev Represents 100% in basis points (10,000 = 100%). uint256 public constant OPTIMISTIC_MODULE_PERCENT_DIVISOR = 10_000; @@ -238,12 +242,6 @@ contract ProposalValidator is OwnableUpgradeable, ReinitializableBase, ISemver { /// @notice Mapping of proposal hash to their corresponding proposal data. mapping(bytes32 => ProposalData) internal _proposals; - /// @notice Semantic version. - /// @custom:semver 1.0.0 - function version() public pure virtual returns (string memory) { - return "1.0.0"; - } - /// @notice Constructs the ProposalValidator contract. /// @param _approvedProposerAttestationSchemaUid The schema UID for attestations in EAS for submitting proposals. /// @param _topDelegatesAttestationSchemaUid The schema UID for attestations in EAS for checking if the caller