Commit cc5f1ab
authored
[action] [PR:18348] argparse conflicting option string (sonic-net#889)
### Description of PR
Two option strings, `--num_routes` and `--skip_cleanup` conflict between a couple of test suites. This causes `./run_tests.sh` when executing test cases simultaneously (such as when running the full suite) to exit with an error of something like:
```
argparse.ArgumentError: argument --num_routes: conflicting option string(s): --num_routes
```
Move these arguments into the global scope from their conflicting locations.
Fixes sonic-net#5526
### Type of change
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [ ] Test case improvement
### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
### Approach
#### What is the motivation for this PR?
Make running all tests pass
#### How did you do it?
Move conflicting options to global scope.
#### How did you verify/test it?
```
./run_tests.sh -n vms-kvm-t0 -d vlab-01 -f vtestbed.yaml -i ../ansible/veos_vtb -e "--neighbor_type=sonic" -t t0,any
```
#### Any platform specific information?
#### Supported testbed topology if it's a new test case?
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->1 parent bc8b8ad commit cc5f1ab
4 files changed
Lines changed: 9 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
134 | 141 | | |
135 | 142 | | |
136 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 38 | | |
45 | 39 | | |
46 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 11 | | |
15 | 12 | | |
16 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 64 | | |
73 | 65 | | |
74 | 66 | | |
| |||
125 | 117 | | |
126 | 118 | | |
127 | 119 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | 120 | | |
135 | 121 | | |
136 | 122 | | |
| |||
261 | 247 | | |
262 | 248 | | |
263 | 249 | | |
| 250 | + | |
| 251 | + | |
264 | 252 | | |
265 | 253 | | |
266 | 254 | | |
| |||
0 commit comments