Skip to content

Commit 5eb2b9e

Browse files
authored
Update checkstyle tool version to 10.14.2 (#3047)
1 parent 091a41c commit 5eb2b9e

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

api/src/main/java/ai/djl/modality/nlp/generate/TextGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ public NDArray greedySearch(NDArray inputIds) throws TranslateException {
134134
* Generates text using beam search.
135135
*
136136
* @param inputIds input tokens ids
137-
* @see <a href="https://huggingface.co/blog/how-to-generate">Beam Search</a>
138137
* @return the output token ids stored as NDArray and the endPosition of each sentence
139138
* @throws TranslateException if failed run forward
139+
* @see <a href="https://huggingface.co/blog/how-to-generate">Beam Search</a>
140140
*/
141141
@SuppressWarnings("try")
142142
public NDArray beamSearch(NDArray inputIds) throws TranslateException {
@@ -261,9 +261,9 @@ public NDArray beamSearch(NDArray inputIds) throws TranslateException {
261261
* Generates text using contrastive search.
262262
*
263263
* @param inputIds input token ids
264-
* @see <a href="https://huggingface.co/blog/introducing-csearch">Contrastive Search</a>
265264
* @return the output token ids stored as NDArray
266265
* @throws TranslateException if forward failed
266+
* @see <a href="https://huggingface.co/blog/introducing-csearch">Contrastive Search</a>
267267
*/
268268
@SuppressWarnings("try")
269269
public NDArray contrastiveSearch(NDArray inputIds) throws TranslateException {

api/src/main/java/ai/djl/training/tracker/LinearTracker.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
*/
1313
package ai.djl.training.tracker;
1414

15-
import ai.djl.training.tracker.WarmUpTracker.Builder;
1615
import ai.djl.util.Preconditions;
1716

1817
/**

tools/conf/checkstyle.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
value="Override, Test, Before, After, BeforeClass, AfterClass"/>
157157
</module>
158158
-->
159-
<module name="FinalClass"/>
160159
<module name="HideUtilityClassConstructor"/>
161160
<module name="InnerTypeLast"/>
162161
<!--
@@ -284,8 +283,8 @@
284283
<!-- Javadoc Comments -->
285284
<module name="AtclauseOrder"/>
286285
<module name="JavadocMethod">
287-
<property name="allowUndeclaredRTE" value="true"/>
288-
<property name="allowThrowsTagsForSubclasses" value="true"/>
286+
<property name="allowMissingParamTags" value="true"/>
287+
<property name="allowMissingReturnTag" value="true"/>
289288
</module>
290289
<module name="JavadocParagraph"/>
291290
<module name="JavadocStyle">

tools/gradle/check.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ tasks.withType(Pmd) {
3535

3636
apply plugin: "checkstyle"
3737
checkstyle {
38-
toolVersion = "8.26"
38+
toolVersion = "10.14.2"
3939
ignoreFailures = false
4040
checkstyleTest.enabled = true
4141
configProperties = [

0 commit comments

Comments
 (0)