Panicking when dropping deadpool-runtime #460
Description
Hello,
I'm having this error randomly when closing my app (so when it drops deadpool):
thread 'tokio-runtime-worker' (4858160) panicked at …/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/deadpool-runtime-0.1.4/src/lib.rs:77:58:
`JoinError` reason is not a panic.: JoinError::Cancelled(Id(4027))
stacktrace
stack backtrace:
0: __rustc::rust_begin_unwind
at /rustc/842bd5be253e17831e318fdbd9d01d716557cc75/library/std/src/panicking.rs:689:5
1: core::panicking::panic_fmt
at /rustc/842bd5be253e17831e318fdbd9d01d716557cc75/library/core/src/panicking.rs:80:14
2: core::result::unwrap_failed
at /rustc/842bd5be253e17831e318fdbd9d01d716557cc75/library/core/src/result.rs:1867:5
3: <core::result::Result<alloc::boxed::Box<dyn core::any::Any + core::marker::Send>, tokio::runtime::task::error::JoinError>>::expect
at …/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/result.rs:1185:23
4: <tokio::runtime::task::error::JoinError>::into_panic
at …/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/error.rs:95:14
5: <deadpool_runtime::Runtime>::spawn_blocking::<<deadpool_sync::SyncWrapper<rusqlite::Connection>>::interact<<deadpool::managed::object::Object<matrix_sdk_sqlite::connection::Manager> as matrix_sdk_sqlite::utils::SqliteAsyncConnExt>::execute_batch<&str>::{closure#0}::{closure#0}, core::result::Result<(), rusqlite::error::Error>>::{closure#0}::{closure#0}, core::result::Result<core::result::Result<(), rusqlite::error::Error>, deadpool_sync::InteractError>>::{closure#0}::{closure#0}
at …/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/deadpool-runtime-0.1.4/src/lib.rs:77:58
6: <core::result::Result<core::result::Result<core::result::Result<(), rusqlite::error::Error>, deadpool_sync::InteractError>, tokio::runtime::task::error::JoinError>>::map_err::<deadpool_runtime::SpawnBlockingError, <deadpool_runtime::Runtime>::spawn_blocking<<deadpool_sync::SyncWrapper<rusqlite::Connection>>::interact<<deadpool::managed::object::Object<matrix_sdk_sqlite::connection::Manager> as matrix_sdk_sqlite::utils::SqliteAsyncConnExt>::execute_batch<&str>::{closure#0}::{closure#0}, core::result::Result<(), rusqlite::error::Error>>::{closure#0}::{closure#0}, core::result::Result<core::result::Result<(), rusqlite::error::Error>, deadpool_sync::InteractError>>::{closure#0}::{closure#0}>
at …/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/result.rs:968:27
7: <deadpool_runtime::Runtime>::spawn_blocking::<<deadpool_sync::SyncWrapper<rusqlite::Connection>>::interact<<deadpool::managed::object::Object<matrix_sdk_sqlite::connection::Manager> as matrix_sdk_sqlite::utils::SqliteAsyncConnExt>::execute_batch<&str>::{closure#0}::{closure#0}, core::result::Result<(), rusqlite::error::Error>>::{closure#0}::{closure#0}, core::result::Result<core::result::Result<(), rusqlite::error::Error>, deadpool_sync::InteractError>>::{closure#0}
at …/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/deadpool-runtime-0.1.4/src/lib.rs:77:18
8: <deadpool_sync::SyncWrapper<rusqlite::Connection>>::interact::<<deadpool::managed::object::Object<matrix_sdk_sqlite::connection::Manager> as matrix_sdk_sqlite::utils::SqliteAsyncConnExt>::execute_batch<&str>::{closure#0}::{closure#0}, core::result::Result<(), rusqlite::error::Error>>::{closure#0}
at …/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/deadpool-sync-0.1.4/src/lib.rs:129:14
9: <deadpool::managed::object::Object<matrix_sdk_sqlite::connection::Manager> as matrix_sdk_sqlite::utils::SqliteAsyncConnExt>::execute_batch::<&str>::{closure#0}
at …/matrix-sdk-sqlite/src/utils.rs:245:69
I'm willing to write a patch to fix that, just I wanted to open an issue first to track the bug.
It happens very frequently, like almost everytime.