fix: remove no-bind-mounts from tests and documentation (#23)

Author: AkibaAT

.github/workflows/test.yml

@@ -20,14 +20,9 @@ jobs:
       -
         name: Docker info
         run: docker info
-      -
-        name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
       -
         name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-        with:
-          platforms: linux/amd64,linux/arm64
       -
         name: Setup bats and bats libs
         id: setup-bats

docs/gitlab-com.md

@@ -20,8 +20,6 @@ ddev-initialize:
     - name: docker:dind
   when: always
   script:
-    # Fix for: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /builds/*/*'
-    - ddev config global --no-bind-mounts=true
     - ddev --version
     # ... do things
 ```

tests/setup_suite.bash

@@ -9,7 +9,28 @@ setup_suite() {
       docker network create "$NETWORK"
   fi
 
-  docker run --privileged -e DOCKER_TLS_CERTDIR="" --name ddev-dind -d --network ddev-docker --network-alias docker docker:dind
+  # Create a shared volume for bind mounts
+  SHARED_VOLUME="ddev-shared-volume"
+  if docker volume inspect "$SHARED_VOLUME" &>/dev/null; then
+      echo "Volume '$SHARED_VOLUME' already exists."
+  else
+      echo "Creating volume '$SHARED_VOLUME'."
+      docker volume create "$SHARED_VOLUME"
+  fi
+
+  # Initialize the shared volume with full permissions
+  docker run --rm \
+    -v "$SHARED_VOLUME:/mnt/ddev-shared" \
+    alpine:latest sh -c "mkdir -p /mnt/ddev-shared && chmod -R 777 /mnt/ddev-shared"
+
+  # Run DIND with the shared volume mounted
+  docker run --privileged -e DOCKER_TLS_CERTDIR="" \
+    --name ddev-dind \
+    -d \
+    --network ddev-docker \
+    --network-alias docker \
+    -v "$SHARED_VOLUME:/mnt/ddev-shared" \
+    docker:dind
   waitForDinD
 }
 
@@ -33,4 +54,5 @@ waitForDinD() {
 teardown_suite() {
   docker stop ddev-dind
   docker rm ddev-dind
+  docker volume rm ddev-shared-volume
 }

tests/test.bats

@@ -42,11 +42,10 @@ setup() {
 
 @test "Create and run a ddev project" {
     local TEST_COMMAND="
-        mkdir ~/ddev-test
-        cd ~/ddev-test
+        mkdir -p /mnt/ddev-shared/ddev-test
+        cd /mnt/ddev-shared/ddev-test
         echo '<?php echo \"Hello World\";' > index.php
         ddev config --project-type php --auto
-        ddev config global --no-bind-mounts=true
         ddev start
         curl https://ddev-test.ddev.site/index.php
         ddev poweroff
@@ -66,13 +65,11 @@ setup() {
     assert_success
 }
 
-# Use "--no-bind-mounts=true" to make "ddev debug test" pass. This is only required in testing environment
 @test "Run ddev debug test" {
     local TEST_COMMAND="
-      mkdir ~/ddev-test
-      cd ~/ddev-test
+      mkdir -p /mnt/ddev-shared/ddev-test-debug
+      cd /mnt/ddev-shared/ddev-test-debug
       ddev config --project-type php --auto
-      ddev config global --no-bind-mounts=true
       ddev debug test
     "
     run docker-run "${TEST_COMMAND}"
@@ -84,5 +81,9 @@ setup() {
 docker-run() {
   local COMMAND=${1}
 
-  docker run --rm -it --network ddev-docker ghcr.io/ddev/ddev-gitlab-ci:"${DDEV_VERSION}" /bin/sh -c "${COMMAND}"
+  # Mount the shared volume to make bind mounts work
+  docker run --rm -it \
+    --network ddev-docker \
+    -v "ddev-shared-volume:/mnt/ddev-shared" \
+    ghcr.io/ddev/ddev-gitlab-ci:"${DDEV_VERSION}" /bin/sh -c "${COMMAND}"
 }