Final 0 9 0 prep (#643)

* Move deprecated macros to a deprecated folder

* Move width_bucket into sql generators

* Warn that some more macros will be removed in future

* Fix BQ seed

Author: joellabes

README.md

@@ -48,6 +48,8 @@ For compatibility details between versions of dbt-core and dbt-utils, [see this
     - [safe_add](#safe_add-source)
     - [pivot](#pivot-source)
     - [unpivot](#unpivot-source)
+    - [width_bucket](#width_bucket-source)
+
 
 - [Web macros](#web-macros)
     - [get_url_parameter](#get_url_parameter-source)
@@ -60,7 +62,6 @@ For compatibility details between versions of dbt-core and dbt-utils, [see this
     - [datediff](#datediff-source)
     - [split_part](#split_part-source)
     - [last_day](#last_day-source)
-    - [width_bucket](#width_bucket-source)
     - [listagg](#listagg-source)
     - [array_construct](#array_construct-source)
     - [array_append](#array_append-source)
@@ -1005,6 +1006,31 @@ Boolean values are replaced with the strings 'true'|'false'
 - `field_name`: column name in the resulting table for field
 - `value_name`: column name in the resulting table for value
 
+#### width_bucket ([source](macros/cross_db_utils/width_bucket.sql))
+This macro is modeled after the `width_bucket` function natively available in Snowflake.
+
+From the original Snowflake [documentation](https://docs.snowflake.net/manuals/sql-reference/functions/width_bucket.html):
+
+Constructs equi-width histograms, in which the histogram range is divided into intervals of identical size, and returns the bucket number into which the value of an expression falls, after it has been evaluated. The function returns an integer value or null (if any input is null).
+Notes:
+
+**Args:**
+- `expr`: The expression for which the histogram is created. This expression must evaluate to a numeric value or to a value that can be implicitly converted to a numeric value.
+
+- `min_value` and `max_value`: The low and high end points of the acceptable range for the expression. The end points must also evaluate to numeric values and not be equal.
+
+- `num_buckets`:  The desired number of buckets; must be a positive integer value. A value from the expression is assigned to each bucket, and the function then returns the corresponding bucket number.
+
+When an expression falls outside the range, the function returns:
+- `0` if the expression is less than min_value.
+- `num_buckets + 1` if the expression is greater than or equal to max_value.
+
+
+**Usage:**
+```
+{{ dbt_utils.width_bucket(expr, min_value, max_value, num_buckets) }}
+```
+
 ### Web macros
 #### get_url_parameter ([source](macros/web/get_url_parameter.sql))
 This macro extracts a url parameter from a column containing a url.
@@ -1092,31 +1118,6 @@ Gets the last day for a given date and datepart. Notes:
 {{ dbt_utils.last_day(date, datepart) }}
 ```
 
-#### width_bucket ([source](macros/cross_db_utils/width_bucket.sql))
-This macro is modeled after the `width_bucket` function natively available in Snowflake.
-
-From the original Snowflake [documentation](https://docs.snowflake.net/manuals/sql-reference/functions/width_bucket.html):
-
-Constructs equi-width histograms, in which the histogram range is divided into intervals of identical size, and returns the bucket number into which the value of an expression falls, after it has been evaluated. The function returns an integer value or null (if any input is null).
-Notes:
-
-**Args:**
-- `expr`: The expression for which the histogram is created. This expression must evaluate to a numeric value or to a value that can be implicitly converted to a numeric value.
-
-- `min_value` and `max_value`: The low and high end points of the acceptable range for the expression. The end points must also evaluate to numeric values and not be equal.
-
-- `num_buckets`:  The desired number of buckets; must be a positive integer value. A value from the expression is assigned to each bucket, and the function then returns the corresponding bucket number.
-
-When an expression falls outside the range, the function returns:
-- `0` if the expression is less than min_value.
-- `num_buckets + 1` if the expression is greater than or equal to max_value.
-
-
-**Usage:**
-```
-{{ dbt_utils.width_bucket(expr, min_value, max_value, num_buckets) }}
-```
-
 #### listagg ([source](macros/cross_db_utils/listagg.sql))
 This macro returns the concatenated input values from a group of rows separated by a specified deliminator.
 

…ests/data/cross_db/data_width_bucket.csv …ion_tests/data/sql/data_width_bucket.csvintegration_tests/data/cross_db/data_width_bucket.csv renamed to integration_tests/data/sql/data_width_bucket.csv integration_tests/data/cross_db/data_width_bucket.csv renamed to integration_tests/data/sql/data_width_bucket.csv

@@ -46,11 +46,6 @@ seeds:
           first_date: timestamp
           second_date: timestamp
 
-      data_width_bucket:
-        +column_types:
-          num_buckets: integer
-          min_value: float
-          max_value: float
 
     sql:
       data_events_20180103:
@@ -60,6 +55,12 @@ seeds:
         # this.incorporate() to hardcode the node's type as otherwise dbt doesn't know it yet
         +post-hook: "{% do adapter.drop_relation(this.incorporate(type='table')) %}"
 
+      data_width_bucket:
+        +column_types:
+          num_buckets: integer
+          min_value: float
+          max_value: float
+
     schema_tests:
       data_test_sequential_timestamps:
         +column_types:

integration_tests/dbt_project.yml

@@ -108,12 +108,6 @@ models:
           expected: expected
 
   - name: test_position
-    tests:
-      - assert_equal:
-          actual: actual
-          expected: expected
-
-  - name: test_width_bucket
     tests:
       - assert_equal:
           actual: actual

integration_tests/models/cross_db_utils/schema.yml

@@ -182,3 +182,9 @@ models:
     tests:
       - dbt_utils.equality:
           compare_model: ref('data_deduplicate_expected')
+
+  - name: test_width_bucket
+    tests:
+      - assert_equal:
+          actual: actual
+          expected: expected

integration_tests/models/sql/schema.yml

@@ -1,4 +1,5 @@
 {% macro array_append(array, new_element) -%}
+  {% do dbt_utils.xdb_deprecation_warning_without_replacement('array_append', model.package_name, model.name) %}
   {{ return(adapter.dispatch('array_append', 'dbt_utils')(array, new_element)) }}
 {%- endmacro %}
 

…els/cross_db_utils/test_width_bucket.sql …n_tests/models/sql/test_width_bucket.sqlintegration_tests/models/cross_db_utils/test_width_bucket.sql renamed to integration_tests/models/sql/test_width_bucket.sql integration_tests/models/cross_db_utils/test_width_bucket.sql renamed to integration_tests/models/sql/test_width_bucket.sql

@@ -1,4 +1,5 @@
 {% macro array_concat(array_1, array_2) -%}
+  {% do dbt_utils.xdb_deprecation_warning_without_replacement('array_concat', model.package_name, model.name) %}
   {{ return(adapter.dispatch('array_concat', 'dbt_utils')(array_1, array_2)) }}
 {%- endmacro %}
 

macros/cross_db_utils/array_append.sql

@@ -1,4 +1,5 @@
 {% macro array_construct(inputs = [], data_type = api.Column.translate_type('integer')) -%}
+  {% do dbt_utils.xdb_deprecation_warning_without_replacement('array_construct', model.package_name, model.name) %}
   {{ return(adapter.dispatch('array_construct', 'dbt_utils')(inputs, data_type)) }}
 {%- endmacro %}
 

macros/cross_db_utils/array_concat.sql

@@ -1,4 +1,5 @@
 {% macro cast_array_to_string(array) %}
+  {% do dbt_utils.xdb_deprecation_warning_without_replacement('cast_array_to_string', model.package_name, model.name) %}
   {{ adapter.dispatch('cast_array_to_string', 'dbt_utils') (array) }}
 {% endmacro %}