Skip to content

Better Error Formatting for Semantic Manifest Validations#12546

Open
sriramr98 wants to merge 2 commits intomainfrom
fix/better_errors_semantic_manifest_validations
Open

Better Error Formatting for Semantic Manifest Validations#12546
sriramr98 wants to merge 2 commits intomainfrom
fix/better_errors_semantic_manifest_validations

Conversation

@sriramr98
Copy link
Contributor

Resolves #9849

Problem

Currently, we print semantic manifest validation errors, but looking at the output, it's not clear which line is the error.

Solution

This PR adds [ERROR] in red colour to highlight the actual error in semantic manifest validations.
Screenshot 2026-02-26 at 4 36 50 PM

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@sriramr98 sriramr98 requested a review from a team as a code owner February 26, 2026 11:07
@cla-bot cla-bot bot added the cla:yes label Feb 26, 2026
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (b0b9004) to head (35e4dac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12546      +/-   ##
==========================================
- Coverage   91.42%   91.37%   -0.05%     
==========================================
  Files         203      203              
  Lines       25550    25551       +1     
==========================================
- Hits        23358    23348      -10     
- Misses       2192     2203      +11     
Flag Coverage Δ
integration 88.18% <100.00%> (-0.11%) ⬇️
unit 65.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.41% <100.00%> (+<0.01%) ⬆️
Integration Tests 88.18% <100.00%> (-0.11%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Improve Semantic Manifest parsing error message

1 participant