Skip to content

Commit ef9bb92

Browse files
add backwards compatibility and default argument for incremental_predicates (#6628) (#6660)
* add backwards compatibility and default argument * changie <3 * Update .changes/unreleased/Fixes-20230117-101342.yaml Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> (cherry picked from commit f841a7c) Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
1 parent f73359b commit ef9bb92

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Fixes
2+
body: Provide backward compatibility for `get_merge_sql` arguments
3+
time: 2023-01-17T10:13:42.118336-06:00
4+
custom:
5+
Author: dave-connors-3
6+
Issue: "6625"

core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
{% macro get_merge_sql(target, source, unique_key, dest_columns, incremental_predicates) -%}
1+
{% macro get_merge_sql(target, source, unique_key, dest_columns, incremental_predicates=none) -%}
2+
-- back compat for old kwarg name
3+
{% set incremental_predicates = kwargs.get('predicates', incremental_predicates) %}
24
{{ adapter.dispatch('get_merge_sql', 'dbt')(target, source, unique_key, dest_columns, incremental_predicates) }}
35
{%- endmacro %}
46

5-
{% macro default__get_merge_sql(target, source, unique_key, dest_columns, incremental_predicates) -%}
7+
{% macro default__get_merge_sql(target, source, unique_key, dest_columns, incremental_predicates=none) -%}
68
{%- set predicates = [] if incremental_predicates is none else [] + incremental_predicates -%}
79
{%- set dest_cols_csv = get_quoted_csv(dest_columns | map(attribute="name")) -%}
810
{%- set merge_update_columns = config.get('merge_update_columns') -%}

0 commit comments

Comments
 (0)