Merge pull request #141 from slhck/add-ci

ci: set up GHA pipeline

Author: davidcelis

.github/workflows/ci.yml

@@ -0,0 +1,32 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        # Test against multiple Ruby versions and pagination libraries
+        # Note: Ruby 3.2/3.3 have 1 pre-existing test failure in Kaminari/WillPaginate
+        # (Fixnum monkey-patching in spec/rails_spec.rb:273)
+        ruby: ['3.1', '3.2', '3.3']
+        paginator: ['pagy', 'kaminari', 'will_paginate']
+    env:
+      PAGINATOR: ${{ matrix.paginator }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rspec

.travis.yml

@@ -3,9 +3,11 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in api_pagination.gemspec
 gemspec
 
-gem 'kaminari', require: false
-gem 'will_paginate', require: false
-gem 'pagy', require: false
+# Explicitly specify version constraints to match gemspec requirements
+# Without these, Bundler may override gemspec constraints and install incompatible versions
+gem 'kaminari', '~> 1.2', '>= 1.2.1', require: false
+gem 'will_paginate', '~> 3.3', '>= 3.3.1', require: false
+gem 'pagy', '>= 9.4.0', '< 10.0.0', require: false
 
 gem 'sqlite3', require: false
-gem 'sequel', require: false
+gem 'sequel', '~> 5.49', require: false

Gemfile

@@ -19,13 +19,13 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '> 2.7'
 
   s.add_development_dependency 'kaminari', '~> 1.2', '>= 1.2.1'
-  s.add_development_dependency 'pagy', '~> 9.0'
+  s.add_development_dependency 'pagy', '>= 9.4.0', '< 10.0.0'
   s.add_development_dependency 'will_paginate', '~> 3.3', '>= 3.3.1'
 
   s.add_development_dependency 'rspec', '~> 3.10'
   s.add_development_dependency 'grape', '~> 1.6'
-  s.add_development_dependency 'railties', '~> 6.1', '>= 6.1.4.1'
-  s.add_development_dependency 'actionpack', '~> 6.1', '>= 6.1.4.1'
+  s.add_development_dependency 'railties', '~> 7.0'
+  s.add_development_dependency 'actionpack', '~> 7.0'
   s.add_development_dependency 'sequel', '~> 5.49'
-  s.add_development_dependency 'activerecord-nulldb-adapter', '~> 0.7.0'
+  s.add_development_dependency 'activerecord-nulldb-adapter', '~> 0.9.0'
 end

api-pagination.gemspec

@@ -70,7 +70,10 @@ def pagy_from(collection, options)
         count = collection.is_a?(Array) ? collection.count : collection.count(:all)
       end
 
-      Pagy.new(count: count, limit: options[:per_page], page: options[:page])
+      # Pagy 9.x requires keyword arguments
+      # Use explicit keyword argument syntax to avoid Ruby version quirks
+      pagy_options = {count: count, limit: options[:per_page], page: options[:page]}
+      Pagy.new(**pagy_options)
     end
 
     def pagy_pages_from(pagy)