tiny

Author: david942j

Rakefile

@@ -10,7 +10,7 @@ import 'tasks/readme.rake'
 task default: %i(readme rubocop compile spec)
 
 RuboCop::RakeTask.new(:rubocop) do |task|
-  task.patterns = ['lib/**/*.rb', 'spec/**/*.rb', 'bin/*', 'tasks/*']
+  task.patterns = ['lib/**/*.rb', 'spec/**/*.rb', 'bin/*', 'tasks/*.rake']
 end
 
 RSpec::Core::RakeTask.new(:spec)

lib/seccomp-tools/asm/asm.rb

@@ -10,10 +10,11 @@ module Asm
 
     # Assembler of seccomp bpf.
     # @param [String] str
+    # @param [:amd64, :i386] arch
     # @return [String]
     #   Raw bpf bytes.
     # @example
-    #   asm(<<EOS)
+    #   SeccompTools::Asm.asm(<<-EOS)
     #     # lines start with '#' are comments
     #     A = sys_number                # here's a comment, too
     #     A >= 0x40000000 ? dead : next # 'next' is a keyword, denote the next instruction

lib/seccomp-tools/consts/sys_nr/amd64.rb

@@ -18,8 +18,8 @@
   rt_sigprocmask: 14,
   rt_sigreturn: 15,
   ioctl: 16,
-  pread: 17,
-  pwrite: 18,
+  pread64: 17,
+  pwrite64: 18,
   readv: 19,
   writev: 20,
   access: 21,

lib/seccomp-tools/consts/sys_nr/i386.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 {
+  setup: 0,
   exit: 1,
   fork: 2,
   read: 3,
@@ -180,8 +181,8 @@
   rt_sigtimedwait: 177,
   rt_sigqueueinfo: 178,
   rt_sigsuspend: 179,
-  pread: 180,
-  pwrite: 181,
+  pread64: 180,
+  pwrite64: 181,
   chown: 182,
   getcwd: 183,
   capget: 184,

lib/seccomp-tools/disasm/context.rb

@@ -96,7 +96,7 @@ def store(idx, reg)
         values[idx] = values[reg.downcase.to_sym]
       end
 
-      # Hints context that current value of register A is equals to +val+.
+      # Hints context that current value of register A equals to +val+.
       #
       # @param [Integer, :x] val
       #   An immediate value or the symbol x.

spec/disasm/context_spec.rb

@@ -56,7 +56,7 @@
     expect(ctx.x.val).to be_zero
   end
 
-  it 'known_eql' do
+  it 'known_data' do
     ctx = described_class.new
     ctx.load(:a, rel: :data, val: 0)
     ctx.eql!(1337)

tasks/syscalls_complement.h

@@ -1,4 +1,4 @@
-/* Complement of syscalls without parameters' names */
+/* Some syscalls in syscalls.h only have prototypes but no argument names, we add them here. */
 asmlinkage long sys_io_submit(aio_context_t ctx_id, long nr, struct iocb __user * __user *iocbpp);
 asmlinkage long sys_pselect6(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp,
                              struct __kernel_timespec __user *tsp, void __user *sig);
@@ -33,11 +33,12 @@ asmlinkage long sys_old_readdir(unsigned int fd, struct old_linux_dirent __user
 asmlinkage long sys_uname(struct old_utsname __user *name);
 asmlinkage long sys_olduname(struct oldold_utsname __user *name);
 
-/* Add manually */
+/* Syscalls not appear in syscalls.h. */
 asmlinkage long sys_arch_prctl(int code, unsigned long addr);
 asmlinkage long sys_mmap(unsigned long addr, unsigned long len, unsigned long prot, unsigned long flags,
   unsigned long fd, unsigned long pgoff);
 
+/* to have i386 compatiable */
 asmlinkage long sys__llseek(unsigned int fd, unsigned long offset_high, unsigned long offset_low, loff_t __user *result,
   unsigned int whence);
 asmlinkage long sys__sysctl(struct __sysctl_args __user *args);