fix: 🐛 fix submitDatasetChallengeProofs

✅ Closes: #377

Author: siriusyim

src/v0.8/module/dataset/DatasetsChallenge.sol

@@ -161,7 +161,7 @@ contract DatasetsChallenge is
         bytes32[] memory roots = _getChallengeRoots(
             _datasetId,
             _randomSeed,
-            getChallengePointsCountRequirement(_datasetId)
+            roles.filplus().datasetRuleChallengePointsPerAuditor()
         );
 
         datasetChallengeProof._submitDatasetChallengeProofs(

test/v0.8/helpers/utils/Generator.sol

@@ -62,7 +62,7 @@ contract Generator {
         for (uint64 i = 0; i < _count; i++) {
             nonce++;
             if (_dataType == DatasetType.DataType.Source) {
-                sizes[i] = nonce * 100;
+                sizes[i] = nonce * 100 + 1024 * 1024 * 1024 * 30;
             } else {
                 sizes[i] = nonce;
             }

test/v0.8/testcases/module/dataset/SubmitProofTestSuite.sol

@@ -367,6 +367,14 @@ contract SubmitProofTestCaseWithInvalidProportion is DatasetsTestBase {
             0
         );
 
+        for (uint64 i = 0; i < sourceLeavesSizes.length; i++) {
+            sourceLeavesSizes[i] =
+                sourceLeavesSizes[i] +
+                1024 *
+                1024 *
+                1024 *
+                30;
+        }
         vm.expectRevert(bytes("Invalid mappingFiles percentage"));
         datasetsAssertion.submitDatasetProofAssertion(
             address(99),

test/v0.8/testcases/module/dataset/SubmittChallengeProofsTestSuite.sol

@@ -69,18 +69,23 @@ contract SubmittChallengeProofsTestCaseWithSuccess is DatasetsTestBase {
         uint64 randomSeed;
 
         datasetsAssertion.isWinnerAssersion(_id, address(199), true);
+        uint64 auditorsRequirement = datasetsChallenge
+            .getChallengeAuditorsCountRequirement(_id);
 
-        (randomSeed, leaves, siblings, paths) = datasetsHelpers
-            .generateVerification(pointCount);
+        for (uint160 i = 0; i < auditorsRequirement; i++) {
+            address caller = address(199 + i);
+            (randomSeed, leaves, siblings, paths) = datasetsHelpers
+                .generateVerification(pointCount);
 
-        datasetsAssertion.submitDatasetChallengeProofsAssertion(
-            address(199),
-            _id,
-            randomSeed,
-            leaves,
-            siblings,
-            paths
-        );
+            datasetsAssertion.submitDatasetChallengeProofsAssertion(
+                caller,
+                _id,
+                randomSeed,
+                leaves,
+                siblings,
+                paths
+            );
+        }
     }
 }
 

test/v0.8/testcases/module/dataset/setup/DatasetsTestSetup.sol

@@ -156,7 +156,7 @@ contract DatasetsTestSetup is Test {
             datasetId,
             DatasetType.DataType.Source,
             "",
-            100,
+            300,
             true
         );
         _datasetsHelpers.submitDatasetProof(
@@ -183,24 +183,35 @@ contract DatasetsTestSetup is Test {
         address _caller
     ) public returns (uint64 id) {
         id = verificationTestSetup(_datasetsHelpers);
-        vm.startPrank(_caller);
-
-        vm.deal(_caller, 1000 ether);
-        _datasetsHelpers.getRoles().finance().deposit{value: 1000 ether}(
-            id,
-            0,
-            _caller,
-            FinanceType.FIL
-        );
-        _datasetsHelpers
+        uint64 auditorsRequirement = _datasetsHelpers
             .getRoles()
             .datasetsChallenge()
-            .nominateAsDatasetAuditorCandidate(id);
-        vm.stopPrank();
+            .getChallengeAuditorsCountRequirement(id);
+
+        for (uint160 i = 0; i < auditorsRequirement; i++) {
+            address caller = address(uint160(_caller) + i);
+            vm.startPrank(caller);
+
+            vm.deal(caller, 1000 ether);
+            _datasetsHelpers.getRoles().finance().deposit{value: 1000 ether}(
+                id,
+                0,
+                caller,
+                FinanceType.FIL
+            );
+            _datasetsHelpers
+                .getRoles()
+                .datasetsChallenge()
+                .nominateAsDatasetAuditorCandidate(id);
+
+            vm.stopPrank();
+        }
+
         uint64 delayBlocks = _datasetsHelpers
             .getRoles()
             .datasetsChallenge()
             .getAuditorElectionEndHeight(id);
+
         vm.roll(delayBlocks);
     }