Simplify session params handling

Address PR review comments by simplifying the session configuration logic.
Always create a new map and copy existing params regardless of whether
metric view metadata is enabled.

This makes the code cleaner and more consistent:
- No nil check needed (ranging over nil map is safe in Go)
- Consistent behavior in all cases
- More readable code

Resolves reviewer comments from @vikrantpuppala, @copilot-pull-request-reviewer, and @gopalldb

Signed-off-by: Shivam Raj <[email protected]>

Author: shivam2680

connector.go

@@ -43,19 +43,12 @@ func (c *connector) Connect(ctx context.Context) (driver.Conn, error) {
 	}
 
 	// Prepare session configuration
-	sessionParams := c.cfg.SessionParams
+	sessionParams := make(map[string]string)
+	for k, v := range c.cfg.SessionParams {
+		sessionParams[k] = v
+	}
+
 	if c.cfg.EnableMetricViewMetadata {
-		// Make a copy of session params and add metric view metadata config
-		if sessionParams == nil {
-			sessionParams = make(map[string]string)
-		} else {
-			// Create a copy to avoid modifying the original
-			paramsCopy := make(map[string]string, len(sessionParams)+1)
-			for k, v := range sessionParams {
-				paramsCopy[k] = v
-			}
-			sessionParams = paramsCopy
-		}
 		sessionParams["spark.sql.thriftserver.metadata.metricview.enabled"] = "true"
 	}