Fix resource leak: close staging Rows in execStagingOperation

vikrantpuppala · claude · vikrantpuppala · commit 20339d3948ae · 2026-02-22T08:39:21.000Z
execStagingOperation creates a Rows object via rows.NewRows() to read staging operation metadata but never closes it. This leaks the Rows object and its RowScanner resources until GC collects them. Add defer row.Close() to ensure proper cleanup. Related: #275 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
diff --git a/connection.go b/connection.go
@@ -592,6 +592,7 @@ func (c *conn) execStagingOperation(
 		if err != nil {
 			return dbsqlerrint.NewDriverError(ctx, "error reading row.", err)
 		}
+		defer row.Close()
 
 	} else {
 		return dbsqlerrint.NewDriverError(ctx, "staging ctx must be provided.", nil)

Original file line number	Diff line number	Diff line change
`@@ -592,6 +592,7 @@ func (c *conn) execStagingOperation(`
`592`	`592`	`if err != nil {`
`593`	`593`	`return dbsqlerrint.NewDriverError(ctx, "error reading row.", err)`
`594`	`594`	`}`
	`595`	`+ defer row.Close()`
`595`	`596`
`596`	`597`	`} else {`
`597`	`598`	`return dbsqlerrint.NewDriverError(ctx, "staging ctx must be provided.", nil)`