Fix data race in analytics global state and update time_duration enum initialization. All tests pass with race detector.

Author: Jefferson Sankara

analytics/analytics.go

@@ -21,7 +21,10 @@ import (
 
 const flushInterval = time.Hour
 
-var Enabled = true
+var (
+	mu      sync.RWMutex
+	Enabled = true
+)
 
 var logger = log.Logger("analytics")
 
@@ -37,6 +40,8 @@ var logger = log.Logger("analytics")
 // Returns:
 //   - An error if there are issues fetching the instance id from the database or if the database appears empty.
 func Init(ctx context.Context, db *gorm.DB) error {
+	mu.Lock()
+	defer mu.Unlock()
 	if Instance != "" {
 		return nil
 	}
@@ -68,6 +73,27 @@ var (
 	Identity string
 )
 
+// GetInstance safely returns the Instance value
+func GetInstance() string {
+	mu.RLock()
+	defer mu.RUnlock()
+	return Instance
+}
+
+// GetIdentity safely returns the Identity value
+func GetIdentity() string {
+	mu.RLock()
+	defer mu.RUnlock()
+	return Identity
+}
+
+// IsEnabled safely returns the Enabled value
+func IsEnabled() bool {
+	mu.RLock()
+	defer mu.RUnlock()
+	return Enabled
+}
+
 type Collector struct {
 	mu            sync.Mutex
 	packJobEvents []PackJobEvent