diff --git a/dask_sql/_compat.py b/dask_sql/_compat.py index 9a80ad0d4..be8cfbae5 100644 --- a/dask_sql/_compat.py +++ b/dask_sql/_compat.py @@ -9,7 +9,6 @@ INDEXER_WINDOW_STEP_IMPLEMENTED = _pandas_version >= parseVersion("1.5.0") PANDAS_GT_200 = _pandas_version >= parseVersion("2.0.0") -PANDAS_GT_210 = _pandas_version >= parseVersion("2.1.0") # TODO: remove if prompt-toolkit min version gets bumped PIPE_INPUT_CONTEXT_MANAGER = _prompt_toolkit_version >= parseVersion("3.0.29") diff --git a/dask_sql/physical/utils/sort.py b/dask_sql/physical/utils/sort.py index f4299e3dc..c35704a32 100644 --- a/dask_sql/physical/utils/sort.py +++ b/dask_sql/physical/utils/sort.py @@ -57,7 +57,7 @@ def apply_sort( by=sort_columns, ascending=sort_ascending[0], na_position="first" if sort_null_first[0] else "last", - ignore_index=True, + # ignore_index=True, ).persist() except ValueError: pass diff --git a/tests/integration/test_compatibility.py b/tests/integration/test_compatibility.py index c55c7b327..7b8808629 100644 --- a/tests/integration/test_compatibility.py +++ b/tests/integration/test_compatibility.py @@ -18,7 +18,6 @@ import pytest from dask_sql import Context -from dask_sql._compat import PANDAS_GT_210 from dask_sql.utils import ParsingException from tests.utils import assert_eq @@ -29,10 +28,8 @@ def cast_datetime_to_string(df): if not cols: return df - strf = "%Y-%m-%dT%H:%M:%S" if PANDAS_GT_210 else "%Y-%m-%d %H:%M:%S" - for col in cols: - df[col] = df[col].dt.strftime(strf) + df[col] = df[col].dt.strftime("%Y-%m-%d %H:%M:%S") return df diff --git a/tests/integration/test_groupby.py b/tests/integration/test_groupby.py index 597ed04c2..92a2464ab 100644 --- a/tests/integration/test_groupby.py +++ b/tests/integration/test_groupby.py @@ -488,7 +488,7 @@ def test_covar_aggregation(c, timeseries_df): pytest.param("gpu_user_table_1", marks=pytest.mark.gpu), ], ) -@pytest.mark.parametrize("split_out", [None, 2, 4]) +@pytest.mark.parametrize("split_out", [1, 2, 4]) def test_groupby_split_out(c, input_table, split_out, request): user_table = request.getfixturevalue(input_table) diff --git a/tests/integration/test_model.py b/tests/integration/test_model.py index 550f9c7ee..e503e6af2 100644 --- a/tests/integration/test_model.py +++ b/tests/integration/test_model.py @@ -88,11 +88,13 @@ def test_training_and_prediction(c, gpu_client): check_trained_model(c, df_name=timeseries) -@pytest.mark.flaky(reruns=8, condition="sys.platform == 'darwin'") @pytest.mark.xfail( sys.platform == "win32", reason="'xgboost.core.XGBoostError: Failed to poll' on Windows only", ) +@pytest.mark.xfail( + sys.platform == "darwin", reason="Intermittent socket errors on macOS", strict=False +) @pytest.mark.parametrize( "gpu_client", [False, pytest.param(True, marks=pytest.mark.gpu)], indirect=True ) @@ -627,7 +629,9 @@ def test_mlflow_export(c, tmpdir): ) -@pytest.mark.flaky(reruns=8, condition="sys.platform == 'darwin'") +@pytest.mark.xfail( + sys.platform == "darwin", reason="Intermittent socket errors on macOS", strict=False +) def test_mlflow_export_xgboost(c, client, tmpdir): # Test only when mlflow & xgboost was installed mlflow = pytest.importorskip("mlflow", reason="mlflow not installed")