Catch the test_runner codebase up to somewhat modern practices.

- Run dartfmt --fix. This converts JavaDoc comments to "///", removes
  "new" and extraneous "const", and a couple of other things.
- Fix SCREAMING_CAPS constants to lowerCamelCase.
- Use collection literals where possible.
- Use UI-as-code in a couple of places where it seemed obvious.
- Use "var" for more local variables.
- Use "const" instead of "final" when possible.
- Make members private when possible. Deleted a few that then became
  obviously unused.
- ".length > 0" -> ".isNotEmpty".

There are no meaningful changes.

Change-Id: Ic6c5a74b2af9b3ebcbe881dbed69f65488bdef09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105880
Commit-Queue: Bob Nystrom <[email protected]>
Reviewed-by: William Hesse <[email protected]>

Author: munificent

pkg/test_runner/bin/http_server.dart

@@ -8,7 +8,7 @@ import 'package:test_runner/src/utils.dart';
 import 'package:test_runner/src/vendored_pkg/args/args.dart';
 
 void main(List<String> arguments) {
-  var parser = new ArgParser();
+  var parser = ArgParser();
   parser.addOption('port',
       abbr: 'p',
       help: 'The main server port we wish to respond to requests.',
@@ -33,7 +33,7 @@ void main(List<String> arguments) {
   if (args['help'] as bool) {
     print(parser.getUsage());
   } else {
-    var servers = new TestingServers(
+    var servers = TestingServers(
         args['build-directory'] as String,
         args['csp'] as bool,
         Runtime.find(args['runtime'] as String),

pkg/test_runner/bin/launch_browser.dart

@@ -2,21 +2,19 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-/**
- * Simple command line interface to launching browsers.
- * Uses the browser_controller framework.
- * The usage is:
- *   DARTBIN launch_browser.dart BROWSER_NAME URL
- * DARTBIN should be the checked in stable binary.
- */
+/// Simple command line interface to launching browsers.
+/// Uses the browser_controller framework.
+/// The usage is:
+///   DARTBIN launch_browser.dart BROWSER_NAME URL
+/// DARTBIN should be the checked in stable binary.
 
 import 'package:test_runner/src/browser_controller.dart';
 import 'package:test_runner/src/configuration.dart';
 
 void printHelp() {
   print("Usage pattern:");
   print("launch_browser.dart browser url");
-  print("Supported browsers: ${Browser.SUPPORTED_BROWSERS}");
+  print("Supported browsers: ${Browser.supportedBrowsers}");
 }
 
 void main(List<String> arguments) {
@@ -34,10 +32,10 @@ void main(List<String> arguments) {
   }
 
   var runtime = Runtime.find(name);
-  var configuration = new TestConfiguration(
-      configuration: new Configuration(
+  var configuration = TestConfiguration(
+      configuration: Configuration(
           "dummy configuration", null, null, null, runtime, null));
   var executable = configuration.browserLocation;
-  var browser = new Browser.byRuntime(runtime, executable);
+  var browser = Browser.byRuntime(runtime, executable);
   browser.start(arguments[1]);
 }

pkg/test_runner/bin/package_testing_support.dart

@@ -11,7 +11,7 @@ void main(List<String> arguments) {
   Repository.uri = Uri.base;
   var configurations = <TestConfiguration>[];
   for (var argument in arguments) {
-    configurations.addAll(new OptionsParser().parse(argument.split(" ")));
+    configurations.addAll(OptionsParser().parse(argument.split(" ")));
   }
   testConfigurations(configurations);
 }

pkg/test_runner/bin/test_runner.dart

@@ -27,7 +27,7 @@ import "package:test_runner/src/test_configurations.dart";
 /// Runs all of the tests specified by the given command line [arguments].
 void main(List<String> arguments) {
   // Parse the command line arguments to a configuration.
-  var parser = new OptionsParser();
+  var parser = OptionsParser();
   var configurations = parser.parse(arguments);
   if (configurations == null || configurations.isEmpty) return;