Skip to content

Commit b9e005f

Browse files
jensjohacommit-bot@chromium.org
authored andcommitted
[fasta] messages_test automatically wraps examples in part
Update the message_test to automatically create an example that wrappes all already defined examples in a part. For instance, if the example is main.dart: main() { print("hello world"); } create an additional example that is basically main_wrapped.dart: part 'main.dart'; main.dart: part of 'main_wrapped.dart'; main() { print("hello world"); } (as well as some additional comments to push any actual positions in the main file ot of scope for valid positions in the wrapper file. This doesn't work for everything, e.g. if the original main imports or exports anything, the new test will fail. That's okay, the status file has been updated accordingly. The reason for adding it is that we currently have some bugs that causes us to crash in situations like this, i.e. situations where a message is coming from a position in a part where the same position doesn't exist in the non-part file. The status file has been updated for that too, although not in sorted order. Change-Id: Ib67f85fca5e81e0b9e93cf2d79ab50c38cae4936 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106082 Reviewed-by: Dmitry Stefantsov <[email protected]> Commit-Queue: Jens Johansen <[email protected]>
1 parent 14fdeb8 commit b9e005f

2 files changed

Lines changed: 182 additions & 3 deletions

File tree

pkg/front_end/messages.status

Lines changed: 125 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,23 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE.md file.
44

5+
# Not sorted --- these crashes should be fixed ASAP!
6+
GenericFunctionTypeInferredAsActualTypeArgument/part_wrapped_script: Crash
7+
GenericFunctionTypeUsedAsActualTypeArgument/part_wrapped_script1: Crash
8+
GenericFunctionTypeUsedAsActualTypeArgument/part_wrapped_script2: Crash
9+
IncorrectTypeArgument/part_wrapped_script: Crash
10+
IncorrectTypeArgumentInReturnType/part_wrapped_script: Crash
11+
IncorrectTypeArgumentInSupertype/part_wrapped_script: Crash
12+
IncorrectTypeArgumentInSupertypeInferred/part_wrapped_script: Crash
13+
IncorrectTypeArgumentInferred/part_wrapped_script: Crash
14+
IncorrectTypeArgumentQualified/part_wrapped_script: Crash
15+
IncorrectTypeArgumentQualifiedInferred/part_wrapped_script: Crash
16+
IntersectionTypeAsTypeArgument/part_wrapped_script: Crash
17+
PartTwice/part_wrapped_script: Crash
18+
519
AbstractClassInstantiation/example: Fail
20+
AbstractClassMember/part_wrapped_script5: Fail
21+
AbstractClassMember/part_wrapped_script6: Fail
622
AbstractClassMember/script5: Fail
723
AbstractClassMember/script6: Fail
824
AbstractNotSync/example: Fail
@@ -11,7 +27,9 @@ AccessError/analyzerCode: Fail
1127
AccessError/example: Fail
1228
AmbiguousSupertypes/example: Fail
1329
AnnotationOnEnumConstant/example: Fail
30+
AnonymousBreakTargetOutsideFunction/part_wrapped_statement: Fail
1431
AnonymousBreakTargetOutsideFunction/statement: Fail # Duplicated error as parser also complains.
32+
AnonymousContinueTargetOutsideFunction/part_wrapped_statement: Fail
1533
AnonymousContinueTargetOutsideFunction/statement: Fail # Duplicated error as parser also complains.
1634
ArgumentTypeNotAssignable/example: Fail
1735
AssertAsExpression/analyzerCode: Fail
@@ -39,10 +57,15 @@ CantInferPackagesFromPackageUri/analyzerCode: Fail
3957
CantInferPackagesFromPackageUri/example: Fail
4058
CantInferTypeDueToCircularity/example: Fail
4159
CantInferTypeDueToInconsistentOverrides/example: Fail
60+
CantReadFile/part_wrapped_script: Fail # Importing file in the (now) part.
4261
CantUseControlFlowOrSpreadAsConstant/example: Fail
62+
CantUseDeferredPrefixAsConstant/part_wrapped_script: Fail # Importing file in the (now) part.
63+
CantUsePrefixAsExpression/part_wrapped_script: Fail # Importing file in the (now) part.
64+
CantUsePrefixWithNullAware/part_wrapped_script: Fail # Importing file in the (now) part.
4365
CantUseSuperBoundedTypeForInstanceCreation/analyzerCode: Fail
4466
CantUseSuperBoundedTypeForInstanceCreation/example: Fail
4567
ColonInPlaceOfIn/example: Fail
68+
ConflictingModifiers/part_wrapped_script1: Fail
4669
ConflictingModifiers/script1: Fail
4770
ConflictsWithConstructor/example: Fail
4871
ConflictsWithFactory/analyzerCode: Fail
@@ -54,6 +77,8 @@ ConflictsWithSetterWarning/example: Fail
5477
ConflictsWithTypeVariable/example: Fail
5578
ConstAndFinal/declaration3: Fail
5679
ConstAndFinal/declaration4: Fail
80+
ConstAndFinal/part_wrapped_declaration3: Fail
81+
ConstAndFinal/part_wrapped_declaration4: Fail
5782
ConstConstructorInSubclassOfMixinApplication/example: Fail
5883
ConstConstructorNonFinalField/example: Fail
5984
ConstConstructorRedirectionToNonConst/analyzerCode: Fail # The analyzer doesn't report this error.
@@ -98,15 +123,24 @@ ConstFieldWithoutInitializer/example: Fail
98123
ConstructorNotFound/example: Fail
99124
ConstructorNotSync/example: Fail
100125
ContinueLabelNotTarget/example: Fail
126+
ContinueOutsideOfLoop/part_wrapped_script1: Fail
101127
ContinueOutsideOfLoop/script1: Fail
128+
ContinueWithoutLabelInCase/part_wrapped_script1: Fail
102129
ContinueWithoutLabelInCase/script1: Fail
103130
CouldNotParseUri/analyzerCode: Fail
104131
CouldNotParseUri/example: Fail
132+
CovariantAndStatic/part_wrapped_script1: Fail
133+
CovariantAndStatic/part_wrapped_script2: Fail
105134
CovariantAndStatic/script1: Fail
106135
CovariantAndStatic/script2: Fail
136+
CovariantMember/part_wrapped_script1: Fail
137+
CovariantMember/part_wrapped_script2: Fail
107138
CovariantMember/script1: Fail
108139
CovariantMember/script2: Fail
140+
CycleInTypeVariables/part_wrapped_script1: Fail
109141
CycleInTypeVariables/script1: Fail # We report an error for each type variable involved in the cycle.
142+
CyclicClassHierarchy/part_wrapped_script1: Fail
143+
CyclicClassHierarchy/part_wrapped_script2: Fail
110144
CyclicClassHierarchy/script1: Fail # We report an error for each class involved in the cycle.
111145
CyclicClassHierarchy/script2: Fail # We report an error for each class involved in the cycle.
112146
CyclicTypedef/example: Fail
@@ -115,28 +149,43 @@ DeferredPrefixDuplicated/example: Fail
115149
DeferredTypeAnnotation/example: Fail
116150
DillOutlineSummary/analyzerCode: Fail
117151
DillOutlineSummary/example: Fail
152+
DirectiveAfterDeclaration/part_wrapped_script1: Fail
153+
DirectiveAfterDeclaration/part_wrapped_script2: Fail
118154
DirectiveAfterDeclaration/script1: Fail
119155
DirectiveAfterDeclaration/script2: Fail
120156
DuplicateDeferred/example: Fail
121157
DuplicatePrefix/example: Fail
122158
DuplicatedDeclarationUse/analyzerCode: Fail # No corresponding analyzer code.
159+
DuplicatedDeclarationUse/part_wrapped_script1: Fail
160+
DuplicatedDeclarationUse/part_wrapped_script2: Fail
123161
DuplicatedDeclarationUse/script1: Fail # This test can't pass.
124162
DuplicatedDeclarationUse/script2: Fail # Wrong error.
125163
DuplicatedDefinition/analyzerCode: Fail
126164
DuplicatedDefinition/example: Fail
165+
DuplicatedExport/part_wrapped_script: Fail # Exporting file in the (now) part.
127166
DuplicatedExportInType/analyzerCode: Fail
128167
DuplicatedExportInType/example: Fail
168+
DuplicatedImportInType/part_wrapped_script: Fail # Importing file in the (now) part.
169+
DuplicatedLibraryExport/part_wrapped_script: Fail # Exporting file in the (now) part.
170+
DuplicatedLibraryImport/part_wrapped_script: Fail # Importing file in the (now) part.
171+
DuplicatedModifier/part_wrapped_script1: Fail
129172
DuplicatedModifier/script1: Fail
130173
DuplicatedName/example: Fail
131174
DuplicatedNamedArgument/example: Fail
132175
DuplicatedParameterName/example: Fail
133176
Encoding/analyzerCode: Fail
134177
EnumConstantSameNameAsEnclosing/example: Fail
135178
EnumInstantiation/example: Fail
179+
EqualityCannotBeEqualityOperand/part_wrapped_script1: Fail
180+
EqualityCannotBeEqualityOperand/part_wrapped_script2: Fail
136181
EqualityCannotBeEqualityOperand/script1: Fail
137182
EqualityCannotBeEqualityOperand/script2: Fail
183+
ExpectedBlock/part_wrapped_script: Fail
138184
ExpectedBlock/script: Fail
185+
ExpectedBlockToSkip/part_wrapped_script: Fail
139186
ExpectedBlockToSkip/script: Fail
187+
ExpectedButGot/part_wrapped_script1: Fail
188+
ExpectedButGot/part_wrapped_script2: Fail
140189
ExpectedButGot/script1: Fail
141190
ExpectedButGot/script2: Fail
142191
ExpectedClassMember/example: Fail
@@ -149,22 +198,43 @@ ExpectedOneExpression/analyzerCode: Fail
149198
ExpectedOneExpression/example: Fail
150199
ExpectedOpenParens/analyzerCode: Fail
151200
ExpectedOpenParens/example: Fail
201+
ExpectedStatement/part_wrapped_statement: Fail
152202
ExpectedStatement/statement: Fail
153203
ExpectedString/example: Fail
154204
ExpectedToken/example: Fail
155205
ExpectedType/example: Fail
156206
ExpectedUri/analyzerCode: Fail
157207
ExpectedUri/example: Fail
158208
ExperimentNotEnabled/example: Fail
209+
ExportAfterPart/part_wrapped_script1: Fail
159210
ExportAfterPart/script1: Fail
160211
ExpressionNotMetadata/analyzerCode: Fail
161212
ExpressionNotMetadata/example: Fail
162213
ExtendingEnum/example: Fail
163214
ExtendingRestricted/example: Fail
215+
ExternalConstructorWithBody/part_wrapped_script1: Fail
164216
ExternalConstructorWithBody/script1: Fail
165217
ExternalConstructorWithFieldInitializers/example: Fail
166218
ExternalFactoryRedirection/example: Fail
219+
ExternalFactoryWithBody/part_wrapped_script1: Fail
167220
ExternalFactoryWithBody/script1: Fail
221+
ExtraneousModifier/part_wrapped_script1: Fail
222+
ExtraneousModifier/part_wrapped_script2: Fail
223+
ExtraneousModifier/part_wrapped_script3: Fail
224+
ExtraneousModifier/part_wrapped_script4: Fail
225+
ExtraneousModifier/part_wrapped_script5: Fail
226+
ExtraneousModifier/part_wrapped_script7: Fail
227+
ExtraneousModifier/part_wrapped_script8: Fail
228+
ExtraneousModifier/part_wrapped_script9: Fail
229+
ExtraneousModifier/part_wrapped_script10: Fail
230+
ExtraneousModifier/part_wrapped_script11: Fail
231+
ExtraneousModifier/part_wrapped_script12: Fail
232+
ExtraneousModifier/part_wrapped_script13: Fail
233+
ExtraneousModifier/part_wrapped_script16: Fail
234+
ExtraneousModifier/part_wrapped_script17: Fail
235+
ExtraneousModifier/part_wrapped_script18: Fail
236+
ExtraneousModifier/part_wrapped_script19: Fail
237+
ExtraneousModifier/part_wrapped_script20: Fail
168238
ExtraneousModifier/script1: Fail
169239
ExtraneousModifier/script10: Fail
170240
ExtraneousModifier/script11: Fail
@@ -196,34 +266,47 @@ FfiStructAnnotation/analyzerCode: Fail
196266
FfiTypeInvalid/analyzerCode: Fail
197267
FfiTypeMismatch/analyzerCode: Fail
198268
FfiTypeUnsized/analyzerCode: Fail
269+
FieldInitializedOutsideDeclaringClass/part_wrapped_script1: Fail
199270
FieldInitializedOutsideDeclaringClass/script1: Fail
271+
FieldInitializerOutsideConstructor/part_wrapped_script1: Fail
200272
FieldInitializerOutsideConstructor/script1: Fail
273+
FinalAndCovariant/part_wrapped_script2: Fail
201274
FinalAndCovariant/script2: Fail
202275
FinalFieldWithoutInitializer/example: Fail
203276
FinalInstanceVariableAlreadyInitialized/example: Fail
204277
ForInLoopElementTypeNotAssignable/example: Fail
205278
ForInLoopExactlyOneVariable/analyzerCode: Fail # The analyzer doesn't recover well.
279+
ForInLoopExactlyOneVariable/part_wrapped_statement: Fail
206280
ForInLoopExactlyOneVariable/statement: Fail # Fasta reports too many errors.
207281
ForInLoopNotAssignable/analyzerCode: Fail # The analyzer reports a different error.
282+
ForInLoopNotAssignable/part_wrapped_statement: Fail
208283
ForInLoopNotAssignable/statement: Fail
209284
ForInLoopTypeNotIterable/example: Fail
210285
ForInLoopWithConstVariable/example: Fail
211286
FunctionTypeDefaultValue/example: Fail
287+
FunctionTypedParameterVar/part_wrapped_script1: Fail
212288
FunctionTypedParameterVar/script1: Fail
213289
GeneratorReturnsValue/example: Fail
214290
GetterNotFound/example: Fail
215291
GetterWithFormals/example: Fail
292+
IllegalAssignmentToNonAssignable/part_wrapped_script1: Fail
216293
IllegalAssignmentToNonAssignable/script1: Fail
217294
IllegalAsyncGeneratorVoidReturnType/analyzerCode: Fail # The analyzer doesn't report this error.
218295
IllegalMixin/example: Fail
219296
IllegalMixinDueToConstructors/example: Fail
220297
IllegalSyncGeneratorVoidReturnType/analyzerCode: Fail # The analyzer doesn't report this error.
298+
ImplementsBeforeExtends/part_wrapped_script: Fail
221299
ImplementsBeforeExtends/script: Fail
300+
ImplementsBeforeOn/part_wrapped_script: Fail
222301
ImplementsBeforeOn/script: Fail
302+
ImplementsBeforeWith/part_wrapped_script: Fail
223303
ImplementsBeforeWith/script: Fail
224304
ImplementsFutureOr/analyzerCode: Fail # The analyzer doesn't report this error.
305+
ImplementsFutureOr/part_wrapped_script1: Fail # Importing file in the (now) part.
225306
ImplicitCallOfNonMethod/example: Fail
307+
ImportAfterPart/part_wrapped_script1: Fail
226308
ImportAfterPart/script1: Fail
309+
IncompatibleRedirecteeFunctionType/part_wrapped_script6: Fail
227310
IncompatibleRedirecteeFunctionType/script6: Fail # Triggers multiple errors.
228311
InitializerForStaticField/example: Fail
229312
InitializerOutsideConstructor/example: Fail
@@ -252,8 +335,13 @@ InvalidPackageUri/example: Fail
252335
InvalidSuperInInitializer/example: Fail
253336
InvalidThisInInitializer/example: Fail
254337
InvalidUseOfNullAwareAccess/example: Fail
338+
InvalidVoid/part_wrapped_script1: Fail
339+
InvalidVoid/part_wrapped_script2: Fail
255340
InvalidVoid/script1: Fail
256341
InvalidVoid/script2: Fail
342+
LibraryDirectiveNotFirst/part_wrapped_script1: Fail # Defining library name in the (now) part.
343+
LibraryDirectiveNotFirst/part_wrapped_script2: Fail
344+
LibraryDirectiveNotFirst/part_wrapped_script3: Fail
257345
LibraryDirectiveNotFirst/script2: Fail
258346
LibraryDirectiveNotFirst/script3: Fail
259347
ListLiteralTooManyTypeArguments/example: Fail
@@ -265,19 +353,27 @@ MetadataTypeArguments/example: Fail
265353
MethodNotFound/example: Fail
266354
MissingArgumentList/analyzerCode: Fail
267355
MissingArgumentList/example: Fail
356+
MissingAssignableSelector/part_wrapped_script1: Fail
268357
MissingAssignableSelector/script1: Fail
358+
MissingAssignmentInInitializer/part_wrapped_script1: Fail
269359
MissingAssignmentInInitializer/script1: Fail
270360
MissingInput/analyzerCode: Fail
271361
MissingInput/example: Fail
272362
MissingMain/analyzerCode: Fail
273363
MissingMain/example: Fail
364+
MissingPartOf/part_wrapped_script: Fail # Using 'part' in the (now) part.
274365
MissingPrefixInDeferredImport/example: Fail
275366
MixinInferenceNoMatchingClass/example: Fail
367+
ModifierOutOfOrder/part_wrapped_script1: Fail
276368
ModifierOutOfOrder/script1: Fail
369+
MultipleExtends/part_wrapped_script: Fail
277370
MultipleExtends/script: Fail
371+
MultipleImplements/part_wrapped_script: Fail
278372
MultipleImplements/script: Fail
279373
MultipleLibraryDirectives/example: Fail
374+
MultipleOnClauses/part_wrapped_script: Fail
280375
MultipleOnClauses/script: Fail
376+
MultipleWith/part_wrapped_script: Fail
281377
MultipleWith/script: Fail
282378
NamedFunctionExpression/example: Fail
283379
NativeClauseShouldBeAnnotation/example: Fail
@@ -286,10 +382,12 @@ NoSuchNamedParameter/example: Fail
286382
NoUnnamedConstructorInObject/analyzerCode: Fail
287383
NoUnnamedConstructorInObject/example: Fail
288384
NonAsciiIdentifier/expression: Fail
385+
NonAsciiIdentifier/part_wrapped_expression: Fail
289386
NonConstConstructor/example: Fail
290387
NonConstFactory/example: Fail
291388
NonInstanceTypeVariableUse/example: Fail
292389
NonNullAwareSpreadIsNull/analyzerCode: Fail # There's no analyzer code for that error yet.
390+
NonPartOfDirectiveInPart/part_wrapped_script1: Fail
293391
NonPartOfDirectiveInPart/script1: Fail
294392
NotAConstantExpression/example: Fail
295393
NotAType/example: Fail
@@ -313,10 +411,19 @@ OverrideTypeVariablesMismatch/example: Fail
313411
PackageNotFound/analyzerCode: Fail
314412
PackageNotFound/example: Fail
315413
PackagesFileFormat/analyzerCode: Fail # Analyzer crashes when .packages file has format error
414+
PartExport/part_wrapped_script: Fail # Exporting file in the (now) part.
415+
PartInPart/part_wrapped_script: Fail # Using 'part' in the (now) part.
416+
PartOfInLibrary/part_wrapped_script: Fail # Importing file in the (now) part.
316417
PartOfLibraryNameMismatch/example: Fail
418+
PartOfSelf/part_wrapped_script: Fail # Using 'part' in the (now) part.
419+
PartOfTwice/part_wrapped_script1: Fail # Using 'part' in the (now) part.
420+
PartOfTwice/part_wrapped_script2: Fail # Using 'part' in the (now) part.
421+
PartOfTwice/part_wrapped_script3: Fail # Using 'part' in the (now) part.
422+
PartOfTwoLibraries/part_wrapped_script: Fail # Defining library name in the (now) part.
317423
PartOfUriMismatch/example: Fail
318424
PartOfUseUri/example: Fail
319425
PartOrphan/analyzerCode: Fail # Analyzer can't handle this situation
426+
PartOrphan/part_wrapped_script: Fail # Already using 'part of' in the (now) part.
320427
PatchClassTypeVariablesMismatch/analyzerCode: Fail
321428
PatchClassTypeVariablesMismatch/example: Fail
322429
PatchDeclarationMismatch/analyzerCode: Fail
@@ -331,7 +438,9 @@ PrefixAfterCombinator/example: Fail
331438
PreviousUseOfName/analyzerCode: Fail
332439
PreviousUseOfName/example: Fail
333440
PrivateNamedParameter/example: Fail
441+
RedirectingConstructorWithBody/part_wrapped_script1: Fail
334442
RedirectingConstructorWithBody/script1: Fail
443+
RedirectionInNonFactory/part_wrapped_script1: Fail
335444
RedirectionInNonFactory/script1: Fail
336445
RedirectionTargetNotFound/example: Fail
337446
RethrowNotCatch/example: Fail
@@ -381,20 +490,34 @@ TooFewArguments/example: Fail
381490
TooManyArguments/example: Fail
382491
TypeAfterVar/example: Fail
383492
TypeArgumentMismatch/example: Fail
493+
TypeArgumentsOnTypeVariable/part_wrapped_script1: Fail
384494
TypeArgumentsOnTypeVariable/script1: Fail
385495
TypeNotFound/example: Fail
386496
TypeVariableDuplicatedName/example: Fail
387497
TypeVariableInStaticContext/declaration1: Fail # Unfortunate message from outline phase.
388498
TypeVariableInStaticContext/declaration2: Fail # Unfortunate message from outline phase.
389499
TypeVariableInStaticContext/declaration3: Fail # Unfortunate message from outline phase.
390500
TypeVariableInStaticContext/declaration4: Fail # Unfortunate message from outline phase.
501+
TypeVariableInStaticContext/part_wrapped_declaration1: Fail
502+
TypeVariableInStaticContext/part_wrapped_declaration2: Fail
503+
TypeVariableInStaticContext/part_wrapped_declaration3: Fail
504+
TypeVariableInStaticContext/part_wrapped_declaration4: Fail
391505
TypeVariableSameNameAsEnclosing/example: Fail
392506
TypedefNotFunction/example: Fail
507+
UnexpectedToken/part_wrapped_script1: Fail
393508
UnexpectedToken/script1: Fail
509+
UnmatchedToken/part_wrapped_script1: Fail
510+
UnmatchedToken/part_wrapped_script3: Fail
394511
UnmatchedToken/script1: Fail
395512
UnmatchedToken/script3: Fail
396513
Unspecified/analyzerCode: Fail
397514
Unspecified/example: Fail
515+
UnterminatedString/part_wrapped_script2: Fail
516+
UnterminatedString/part_wrapped_script4: Fail
517+
UnterminatedString/part_wrapped_script5: Fail
518+
UnterminatedString/part_wrapped_script6: Fail
519+
UnterminatedString/part_wrapped_script7: Fail
520+
UnterminatedString/part_wrapped_script8: Fail
398521
UnterminatedString/script2: Fail
399522
UnterminatedString/script4: Fail
400523
UnterminatedString/script5: Fail
@@ -403,6 +526,8 @@ UnterminatedString/script7: Fail
403526
UnterminatedString/script8: Fail
404527
UnterminatedToken/analyzerCode: Fail
405528
UnterminatedToken/example: Fail
529+
UntranslatableUri/part_wrapped_script: Fail # Importing file in the (now) part.
530+
VarAsTypeName/part_wrapped_script1: Fail
406531
VarAsTypeName/script1: Fail # Too many problems
407532
WebLiteralCannotBeRepresentedExactly/analyzerCode: Fail
408533
WebLiteralCannotBeRepresentedExactly/example: Fail

0 commit comments

Comments
 (0)