Skip to content

Commit 8828aca

Browse files
munificentcommit-bot@chromium.org
authored andcommitted
Add an analysis_options.yaml file for test_runner.
I didn't realize they were being gitignored across the entire SDK repo. I'm not sure why they are ignored at all, but based on the linked bug, I think it's only a top-level analysis_options.yaml file that would cause problems? This change to the .gitignore file prohibits that case while still allowing analysis_options.yaml files in subdirectories. I very strongly want to have an options file for test_runner to ensure that everyone on the team keeps it "no-implicit-cast" clean. Change-Id: I9ceac507b08a063e71e2fe39501161723651e6b8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106840 Commit-Queue: Bob Nystrom <[email protected]> Reviewed-by: Daco Harkes <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent da8cb47 commit 8828aca

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.gitignore

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,15 @@ cmake-build-debug
4646
.vscode
4747
.history
4848

49+
# https://github.com/Dart-Code/Dart-Code/issues/1295
50+
/analysis_options.yaml
51+
4952
# analysis server files
50-
analysis_options.yaml
5153
compile_commands.json
5254

5355
# GDB files
5456
.gdb_history
5557

56-
# https://github.com/Dart-Code/Dart-Code/issues/1295
57-
analysis_options.yaml
58-
5958
# Built by chromebot and downloaded from Google Storage
6059
client/tests/drt
6160

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
analyzer:
2+
strong-mode:
3+
implicit-casts: false

0 commit comments

Comments
 (0)