Log when LSP drops invalid notifications to the instrumentation log

Change-Id: I8388bf7fe42134fd20d9c7b9727a1f47e4d5a277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107285
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Danny Tuppeny <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/lsp/handlers/handler_states.dart

@@ -122,6 +122,8 @@ class InitializingStateMessageHandler extends ServerStateMessageHandler {
   ErrorOr<void> handleUnknownMessage(IncomingMessage message) {
     // Silently drop non-requests.
     if (message is! RequestMessage) {
+      server.instrumentationService
+          .logInfo('Ignoring ${message.method} message while initializing');
       return success();
     }
     return error(
@@ -142,6 +144,8 @@ class UninitializedStateMessageHandler extends ServerStateMessageHandler {
   FutureOr<ErrorOr<Object>> handleUnknownMessage(IncomingMessage message) {
     // Silently drop non-requests.
     if (message is! RequestMessage) {
+      server.instrumentationService
+          .logInfo('Ignoring ${message.method} message while uninitialized');
       return success();
     }
     return error(ErrorCodes.ServerNotInitialized,
@@ -159,6 +163,8 @@ class ShuttingDownStateMessageHandler extends ServerStateMessageHandler {
   FutureOr<ErrorOr<Object>> handleUnknownMessage(IncomingMessage message) {
     // Silently drop non-requests.
     if (message is! RequestMessage) {
+      server.instrumentationService
+          .logInfo('Ignoring ${message.method} message while shutting down');
       return success();
     }
     return error(ErrorCodes.InvalidRequest,

pkg/analyzer/lib/instrumentation/instrumentation.dart

@@ -70,6 +70,7 @@ class InstrumentationService {
   static const String TAG_ERROR = 'Err';
   static const String TAG_EXCEPTION = 'Ex';
   static const String TAG_FILE_READ = 'Read';
+  static const String TAG_INFO = 'Info';
   static const String TAG_LOG_ENTRY = 'Log';
   static const String TAG_NOTIFICATION = 'Noti';
   static const String TAG_PERFORMANCE = 'Perf';
@@ -163,6 +164,11 @@ class InstrumentationService {
     }
   }
 
+  /**
+   * Log unstructured text information for debugging purposes.
+   */
+  void logInfo(String message) => _log(TAG_INFO, message);
+
   /**
    * Log that a log entry that was written to the analysis engine's log. The log
    * entry has the given [level] and [message], and was created at the given