[linter] Move sinceSdk information to messages file

Continuing work towards consolidating documentation-related information to the messages.yaml file.

Change-Id: I6c80dfae9ed20372c4207c6f007d26e735925a08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386823
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: parlough

pkg/linter/messages.yaml

@@ -15,7 +15,6 @@ import 'package:yaml/yaml.dart';
 
 import '../tool/util/path_utils.dart';
 import 'messages_data.dart';
-import 'since.dart';
 import 'util/score_utils.dart' as score_utils;
 
 /// Generates a list of lint rules in machine format suitable for consumption by
@@ -48,15 +47,14 @@ Future<String> generateRulesJson({
   registerLintRules();
   var fixStatusMap = readFixStatusMap();
   return await getMachineListing(Registry.ruleRegistry,
-      fixStatusMap: fixStatusMap, sinceInfo: sinceMap, pretty: pretty);
+      fixStatusMap: fixStatusMap, pretty: pretty);
 }
 
 Future<String> getMachineListing(
   Iterable<LintRule> ruleRegistry, {
   Map<String, String>? fixStatusMap,
   bool pretty = true,
   bool includeSetInfo = true,
-  Map<String, SinceInfo>? sinceInfo,
 }) async {
   var rules = List<LintRule>.of(ruleRegistry, growable: false)
     ..sort((a, b) => a.name.compareTo(b.name));
@@ -71,6 +69,7 @@ Future<String> getMachineListing(
 
   var categories = messagesYaml.categoryMappings;
   var deprecatedDetails = messagesYaml.deprecatedDetails;
+  var addedIn = messagesYaml.addedIn;
   var json = encoder.convert([
     for (var rule in rules.where((rule) => !rule.state.isInternal))
       {
@@ -87,8 +86,7 @@ Future<String> getMachineListing(
         'fixStatus':
             fixStatusMap[rule.lintCodes.first.uniqueName] ?? 'unregistered',
         'details': deprecatedDetails[rule.name],
-        if (sinceInfo != null)
-          'sinceDartSdk': sinceInfo[rule.name]?.sinceDartSdk ?? 'Unreleased',
+        'sinceDartSdk': addedIn[rule.name] ?? 'Unreleased',
       }
   ]);
   return json;

pkg/linter/tool/machine.dart

@@ -16,6 +16,34 @@ final MessagesData messagesYaml = () {
 final String _messagesYamlPath = pathRelativeToPackageRoot(['messages.yaml']);
 
 extension type MessagesData(YamlMap _map) {
+  Map<String, String> get addedIn {
+    var result = <String, String>{};
+
+    for (var MapEntry(key: String name, value: YamlMap data)
+        in lintCodes.entries) {
+      if (data['addedIn'] case String addedInString) {
+        if (data.containsKey('sharedName')) {
+          name = data['sharedName'] as String;
+        }
+
+        if (addedInString.split('.').length < 2) {
+          throw StateError("Lint $name's 'addedIn' version must be "
+              'at least a major.minor version.');
+        }
+
+        var oldResult = result[name];
+        if (oldResult != null && oldResult == addedInString) {
+          throw StateError("Lint $name has a different 'addedIn' value "
+              'between its shared codes!');
+        }
+
+        result[name] = addedInString;
+      }
+    }
+
+    return result;
+  }
+
   Map<String, Set<String>> get categoryMappings {
     var result = <String, Set<String>>{};
 

pkg/linter/tool/machine/rules.json

@@ -14,7 +14,6 @@ import 'package:path/path.dart' as path;
 import '../test/test_constants.dart';
 import 'changelog.dart';
 import 'messages_data.dart';
-import 'since.dart';
 
 /// Generates rule and rule test stub files (into `src/rules` and `test/rules`
 /// respectively), as well as the rule index (`rules.dart`).
@@ -94,8 +93,6 @@ void generateRule(String ruleName, {String? outDir}) {
   generateFile(ruleName, 'example', _generateAllYaml,
       outDir: outDir, overwrite: true);
 
-  printToConsole('Updating ${SdkVersionFile.filePath}');
-  SdkVersionFile().addRule(ruleName);
   printToConsole('Updating ${Changelog.fileName}');
   Changelog().addEntry(RuleStateChange.added, ruleName);
 

pkg/linter/tool/messages_data.dart

@@ -16,7 +16,6 @@ import 'package:linter/src/utils.dart';
 import '../tool/util/path_utils.dart';
 import 'crawl.dart';
 import 'parse.dart';
-import 'since.dart';
 
 void main() async {
   var scorecard = await ScoreCard.calculate();
@@ -124,16 +123,15 @@ class LintScore {
   String name;
   bool hasFix;
   State state;
-  SinceInfo? since;
 
   List<String> ruleSets;
 
-  LintScore(
-      {required this.name,
-      required this.hasFix,
-      required this.state,
-      required this.ruleSets,
-      this.since});
+  LintScore({
+    required this.name,
+    required this.hasFix,
+    required this.state,
+    required this.ruleSets,
+  });
 
   String get _ruleSets => ruleSets.isNotEmpty ? ' $ruleSets' : '';
 
@@ -143,8 +141,6 @@ class LintScore {
       switch (detail) {
         case Detail.rule:
           sb.write(' [$name](https://dart.dev/lints/$name) |');
-        case Detail.sdk:
-          sb.write(' ${since!.sinceDartSdk} |');
         case Detail.fix:
           sb.write('${hasFix ? " $bulb" : ""} |');
         case Detail.flutterUser:
@@ -210,12 +206,12 @@ class ScoreCard {
       }
 
       scorecard.add(LintScore(
-          name: lint.name,
-          hasFix: lintsWithFixes.contains(lint.name) ||
-              lintsWithAssists.contains(lint.name),
-          state: lint.state,
-          ruleSets: ruleSets,
-          since: sinceMap[lint.name]));
+        name: lint.name,
+        hasFix: lintsWithFixes.contains(lint.name) ||
+            lintsWithAssists.contains(lint.name),
+        state: lint.state,
+        ruleSets: ruleSets,
+      ));
     }
 
     return scorecard;