Skip to content

Commit 348e030

Browse files
jwrencommit-bot@chromium.org
authored andcommitted
Incremental refactoring in index.dart to setup the addition of the missing visitPartOfDirective()
Change-Id: I247db3ad49f928aaec0884aa8d99e603d5a26318 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106966 Reviewed-by: Jaime Wren <jwren@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Jaime Wren <jwren@google.com> Auto-Submit: Jaime Wren <jwren@google.com>
1 parent 86622fe commit 348e030

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

pkg/analyzer/lib/src/dart/analysis/index.dart

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -533,9 +533,8 @@ class _IndexContributor extends GeneralizingAstVisitor {
533533
}
534534
}
535535

536-
void recordUriReference(Element element, UriBasedDirective directive) {
537-
recordRelation(
538-
element, IndexRelationKind.IS_REFERENCED_BY, directive.uri, true);
536+
void recordUriReference(Element element, StringLiteral uri) {
537+
recordRelation(element, IndexRelationKind.IS_REFERENCED_BY, uri, true);
539538
}
540539

541540
@override
@@ -603,7 +602,7 @@ class _IndexContributor extends GeneralizingAstVisitor {
603602
@override
604603
visitExportDirective(ExportDirective node) {
605604
ExportElement element = node.element;
606-
recordUriReference(element?.exportedLibrary, node);
605+
recordUriReference(element?.exportedLibrary, node.uri);
607606
super.visitExportDirective(node);
608607
}
609608

@@ -632,7 +631,7 @@ class _IndexContributor extends GeneralizingAstVisitor {
632631
@override
633632
visitImportDirective(ImportDirective node) {
634633
ImportElement element = node.element;
635-
recordUriReference(element?.importedLibrary, node);
634+
recordUriReference(element?.importedLibrary, node.uri);
636635
super.visitImportDirective(node);
637636
}
638637

@@ -686,7 +685,7 @@ class _IndexContributor extends GeneralizingAstVisitor {
686685
visitPartDirective(PartDirective node) {
687686
CompilationUnitElement element = node.element;
688687
if (element?.source != null) {
689-
recordUriReference(element, node);
688+
recordUriReference(element, node.uri);
690689
}
691690
super.visitPartDirective(node);
692691
}

0 commit comments

Comments
 (0)