[linter] Generate lint codes from messages file

Change-Id: Id4f7ee5843a4063d1e527c1566847d88b355c614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373725
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: parlough

pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart

@@ -16,7 +16,7 @@ import 'package:analyzer_plugin/utilities/assist/assist.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_dart.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
-import 'package:linter/src/rules/diagnostic_describe_all_properties.dart';
+import 'package:linter/src/linter_lint_codes.dart';
 
 class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer {
   AddDiagnosticPropertyReference({required super.context});
@@ -347,7 +347,7 @@ class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer {
     for (var error in unitResult.errors) {
       var errorCode = error.errorCode;
       if (errorCode.type == ErrorType.LINT &&
-          errorCode == DiagnosticDescribeAllProperties.code &&
+          errorCode == LinterLintCode.diagnostic_describe_all_properties &&
           error.offset > startOffset &&
           error.offset < endOffset) {
         propertyErrors.add(error);

pkg/analysis_server/lib/src/services/correction/dart/remove_comparison.dart

@@ -12,7 +12,7 @@ import 'package:analyzer/src/error/codes.g.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
-import 'package:linter/src/rules/avoid_null_checks_in_equality_operators.dart';
+import 'package:linter/src/linter_lint_codes.dart';
 
 class RemoveComparison extends ResolvedCorrectionProducer {
   @override
@@ -49,7 +49,7 @@ class RemoveComparison extends ResolvedCorrectionProducer {
     return errorCode == WarningCode.UNNECESSARY_NAN_COMPARISON_TRUE ||
         errorCode == WarningCode.UNNECESSARY_NULL_COMPARISON_TRUE ||
         errorCode == WarningCode.UNNECESSARY_TYPE_CHECK_TRUE ||
-        errorCode == AvoidNullChecksInEqualityOperators.code;
+        errorCode == LinterLintCode.avoid_null_checks_in_equality_operators;
   }
 
   @override

pkg/analysis_server/lib/src/services/correction/dart/replace_with_decorated_box.dart

@@ -11,7 +11,7 @@ import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
-import 'package:linter/src/rules/use_decorated_box.dart';
+import 'package:linter/src/linter_lint_codes.dart';
 
 class ReplaceWithDecoratedBox extends ResolvedCorrectionProducer {
   ReplaceWithDecoratedBox({required super.context});
@@ -116,7 +116,7 @@ class ReplaceWithDecoratedBox extends ResolvedCorrectionProducer {
     return unitResult.errors.any((error) {
       var errorCode = error.errorCode;
       return errorCode.type == ErrorType.LINT &&
-          errorCode == UseDecoratedBox.code &&
+          errorCode == LinterLintCode.use_decorated_box &&
           error.offset == constructorName.offset &&
           error.length == constructorName.length;
     });

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -1846,17 +1846,21 @@ HintCode.UNNECESSARY_IMPORT:
   status: hasFix
 HintCode.UNREACHABLE_SWITCH_CASE:
   status: hasFix
-LintCode.always_declare_return_types:
+LintCode.always_declare_return_types_of_functions:
+  status: hasFix
+LintCode.always_declare_return_types_of_methods:
   status: hasFix
 LintCode.always_put_control_body_on_new_line:
   status: hasFix
 LintCode.always_put_required_named_parameters_first:
   status: hasFix
-LintCode.always_require_non_null_named_parameters:
-  status: noFix
-  notes: |-
-    Removed.
-LintCode.always_specify_types:
+LintCode.always_specify_types_add_type:
+  status: hasFix
+LintCode.always_specify_types_replace_keyword:
+  status: hasFix
+LintCode.always_specify_types_specify_type:
+  status: hasFix
+LintCode.always_specify_types_split_to_types:
   status: hasFix
 LintCode.always_use_package_imports:
   status: hasFix
@@ -1866,10 +1870,6 @@ LintCode.annotate_redeclares:
   status: hasFix
 LintCode.avoid_annotating_with_dynamic:
   status: hasFix
-LintCode.avoid_as:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.avoid_bool_literals_in_conditional_expressions:
   status: needsFix
   notes: |-
@@ -1943,15 +1943,9 @@ LintCode.avoid_renaming_method_parameters:
   status: hasFix
 LintCode.avoid_return_types_on_setters:
   status: hasFix
-LintCode.avoid_returning_null:
-  status: noFix
-  notes: |-
-    Deprecated.
-LintCode.avoid_returning_null_for_future:
-  status: noFix
-  notes: |-
-    Removed.
-LintCode.avoid_returning_null_for_void:
+LintCode.avoid_returning_null_for_void_from_function:
+  status: hasFix
+LintCode.avoid_returning_null_for_void_from_method:
   status: hasFix
 LintCode.avoid_returning_this:
   status: noFix
@@ -1985,9 +1979,6 @@ LintCode.avoid_types_on_closure_parameters:
   status: hasFix
 LintCode.avoid_unnecessary_containers:
   status: hasFix
-LintCode.avoid_unstable_final_fields:
-  status: noFix
-  notes: This lint is deprecated.
 LintCode.avoid_unused_constructor_parameters:
   status: hasFix
 LintCode.avoid_void_async:
@@ -2039,17 +2030,31 @@ LintCode.dangling_library_doc_comments:
   status: hasFix
 LintCode.depend_on_referenced_packages:
   status: needsFix
-LintCode.deprecated_consistency:
+LintCode.deprecated_consistency_constructor:
   status: needsFix
   notes: |-
     The fix is to either remove deprecated or to add it in the missing places.
-LintCode.deprecated_member_use_from_same_package:
+LintCode.deprecated_consistency_field:
+  status: needsFix
+  notes: |-
+    The fix is to either remove deprecated or to add it in the missing places.
+LintCode.deprecated_consistency_parameter:
+  status: needsFix
+  notes: |-
+    The fix is to either remove deprecated or to add it in the missing places.
+LintCode.deprecated_member_use_from_same_package_without_message:
   status: hasFix
 LintCode.deprecated_member_use_from_same_package_with_message:
   status: hasFix
 LintCode.diagnostic_describe_all_properties:
   status: hasFix
-LintCode.directives_ordering:
+LintCode.directives_ordering_alphabetical:
+  status: hasFix
+LintCode.directives_ordering_dart:
+  status: hasFix
+LintCode.directives_ordering_exports:
+  status: hasFix
+LintCode.directives_ordering_package_before_relative:
   status: hasFix
 LintCode.discarded_futures:
   status: hasFix
@@ -2066,10 +2071,6 @@ LintCode.empty_constructor_bodies:
   status: hasFix
 LintCode.empty_statements:
   status: hasFix
-LintCode.enable_null_safety:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.eol_at_end_of_file:
   status: hasFix
 LintCode.erase_dart_type_extension_types:
@@ -2096,20 +2097,24 @@ LintCode.implicit_reopen:
   status: hasFix
 LintCode.invalid_case_patterns:
   status: hasFix
-LintCode.invalid_runtime_check_with_js_interop_types:
-  status: needsFix
+LintCode.invalid_runtime_check_with_js_interop_types_dart_as_js:
+  status: needsEvaluation
   notes: |-
     The fix is dependent on the specific types that are being used. In some
     cases, the type test is incorrect and has no fix besides removing the test.
     In other cases, JS interop helpers may be used to do the type test instead.
-LintCode.invariant_booleans:
-  status: noFix
-  notes: |-
-    Removed.
-LintCode.iterable_contains_unrelated_type:
-  status: noFix
-  notes: |-
-    Removed.
+LintCode.invalid_runtime_check_with_js_interop_types_dart_is_js:
+  status: needsEvaluation
+LintCode.invalid_runtime_check_with_js_interop_types_js_as_dart:
+  status: needsEvaluation
+LintCode.invalid_runtime_check_with_js_interop_types_js_as_incompatible_js:
+  status: needsEvaluation
+LintCode.invalid_runtime_check_with_js_interop_types_js_is_dart:
+  status: needsEvaluation
+LintCode.invalid_runtime_check_with_js_interop_types_js_is_inconsistent_js:
+  status: needsEvaluation
+LintCode.invalid_runtime_check_with_js_interop_types_js_is_unrelated_js:
+  status: needsEvaluation
 LintCode.join_return_with_assignment:
   status: needsFix
 LintCode.leading_newlines_in_multiline_strings:
@@ -2132,10 +2137,6 @@ LintCode.library_private_types_in_public_api:
     to make the private type public, which (sort of) requires a refactoring.
 LintCode.lines_longer_than_80_chars:
   status: noFix
-LintCode.list_remove_unrelated_type:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.literal_only_boolean_expressions:
   status: noFix
 LintCode.matching_super_parameters:
@@ -2231,10 +2232,6 @@ LintCode.prefer_asserts_in_initializer_lists:
     The fix is to move the assert to the initializer list.
 LintCode.prefer_asserts_with_message:
   status: noFix
-LintCode.prefer_bool_in_asserts:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.prefer_collection_literals:
   status: hasFix
 LintCode.prefer_conditional_assignment:
@@ -2251,19 +2248,21 @@ LintCode.prefer_constructors_over_static_methods:
   status: needsFix
   notes: |-
     The fix is to rewrite the static method as a factory constructor.
-LintCode.prefer_contains:
+LintCode.prefer_contains_always_false:
+  status: hasFix
+LintCode.prefer_contains_always_true:
+  status: hasFix
+LintCode.prefer_contains_use_contains:
   status: hasFix
 LintCode.prefer_double_quotes:
   status: hasFix
-LintCode.prefer_equal_for_default_values:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.prefer_expression_function_bodies:
   status: hasFix
 LintCode.prefer_final_fields:
   status: hasFix
-LintCode.prefer_final_in_for_each:
+LintCode.prefer_final_in_for_each_pattern:
+  status: hasFix
+LintCode.prefer_final_in_for_each_variable:
   status: hasFix
 LintCode.prefer_final_locals:
   status: hasFix
@@ -2285,13 +2284,21 @@ LintCode.prefer_if_null_operators:
   status: hasFix
 LintCode.prefer_initializing_formals:
   status: hasFix
-LintCode.prefer_inlined_adds:
+LintCode.prefer_inlined_adds_multiple:
+  status: hasFix
+LintCode.prefer_inlined_adds_single:
   status: hasFix
 LintCode.prefer_int_literals:
   status: hasFix
 LintCode.prefer_interpolation_to_compose_strings:
   status: hasFix
-LintCode.prefer_is_empty:
+LintCode.prefer_is_empty_always_false:
+  status: hasFix
+LintCode.prefer_is_empty_always_true:
+  status: hasFix
+LintCode.prefer_is_empty_use_is_empty:
+  status: hasFix
+LintCode.prefer_is_empty_use_is_not_empty:
   status: hasFix
 LintCode.prefer_is_not_empty:
   status: hasFix
@@ -2315,7 +2322,9 @@ LintCode.prefer_single_quotes:
   status: hasFix
 LintCode.prefer_spread_collections:
   status: hasFix
-LintCode.prefer_typing_uninitialized_variables:
+LintCode.prefer_typing_uninitialized_variables_for_field:
+  status: hasFix
+LintCode.prefer_typing_uninitialized_variables_for_local_variable:
   status: hasFix
 LintCode.prefer_void_to_null:
   status: hasFix
@@ -2329,6 +2338,8 @@ LintCode.public_member_api_docs:
   status: noFix
 LintCode.recursive_getters:
   status: noFix
+LintCode.removed_lint:
+  status: noFix
 LintCode.require_trailing_commas:
   status: hasFix
 LintCode.secure_pubspec_urls:
@@ -2349,10 +2360,6 @@ LintCode.sort_pub_dependencies:
   status: needsFix
 LintCode.sort_unnamed_constructors_first:
   status: hasFix
-LintCode.super_goes_last:
-  status: noFix
-  notes: |-
-    Removed.
 LintCode.test_types_in_equals:
   status: noFix
 LintCode.throw_in_finally:
@@ -2381,7 +2388,9 @@ LintCode.unnecessary_const:
   status: hasFix
 LintCode.unnecessary_constructor_name:
   status: hasFix
-LintCode.unnecessary_final:
+LintCode.unnecessary_final_with_type:
+  status: hasFix
+LintCode.unnecessary_final_without_type:
   status: hasFix
 LintCode.unnecessary_getters_setters:
   status: hasFix
@@ -2425,9 +2434,9 @@ LintCode.unnecessary_to_list_in_spreads:
   status: hasFix
 LintCode.unreachable_from_main:
   status: hasFix
-LintCode.unrelated_type_equality_checks_expression:
+LintCode.unrelated_type_equality_checks_in_expression:
   status: needsEvaluation
-LintCode.unrelated_type_equality_checks_pattern:
+LintCode.unrelated_type_equality_checks_in_pattern:
   status: needsEvaluation
 LintCode.unsafe_html_attribute:
   status: noFix
@@ -2477,10 +2486,12 @@ LintCode.use_string_buffers:
     It isn't clear that this occurs often enough to justify the cost.
 LintCode.use_string_in_part_of_directives:
   status: hasFix
-LintCode.use_super_parameters:
-  status: hasFix
 LintCode.use_test_throws_matchers:
   status: needsFix
+LintCode.use_super_parameters_multiple:
+  status: hasFix
+LintCode.use_super_parameters_single:
+  status: hasFix
 LintCode.use_to_and_as_if_applicable:
   status: noFix
   notes: |-