Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 5, 2025

When updating the ObjC example, I noticed that the initWithContentsOfURL should be throwing the error, not taking it as an out-param. Turns out that this API was bypassing the heuristic because the param's originalName was outError, not error, and it's a nullable error pointer pointer. So I've updated the heuristic to handle these cases.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 8.1.0 9.0.0-dev.0 9.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Nov 5, 2025

Coverage Status

coverage: 82.509% (+0.06%) from 82.451%
when pulling c804da0 on ffigen_error_edge_cases
into d2edd93 on main.

@liamappelbe liamappelbe merged commit 18d7691 into main Nov 5, 2025
32 checks passed
@liamappelbe liamappelbe deleted the ffigen_error_edge_cases branch November 5, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants