Conditionally disable fakes

[cadaniel]

I'm using the generator, and I'm having troubles with the generated fake classes from moor.

Object.==' ('bool Function(Object)') isn't a valid concrete implementation of 'User.==' ('bool Function(dynamic)').

I've opened an issue with moor at simolus3/drift#1192 but in the mean time, I would like to conidtionally disable Fakes. I don't use them when stubbing personally, instead feeding 'real' classes.

[srawlins]

Thanks for opening an issue.

The code you point to is probably in a generated mock, not a generated fake.

[cadaniel]

@srawlins

The offending line of code is

class _FakeUser extends _i1.Fake implements _i3.User {}

It is inside of a generated mock yes.

[srawlins]

Ah that is very interesting. Even this tiny snippet results in the error you show:

class User {
  bool operator == (dynamic other) => true;
}

class FakeUser extends Fake implements User {}

class Fake {
  dynamic noSuchMethod(_) {}
}

I really think the Moor classes should not override operator == to accept a dynamic parameter...

In any case, this class is required in order to generate your mocks. If you search the generated library for references to _FakeUser, you will see where it is needed.

[cadaniel]

I'm sssoooo close to being able to use the generator again. I don't use the Fakes anyways, is there a way to turn them off for now?

[srawlins]

No. If a fake is referenced in the generated library, then it is necessary. Otherwise the code would reference a type which doesn't exist.

[cadaniel]

That's not 100% true.

EDIT: Give me a moment and I'll find a better one that isn't a stream.

So here's a function that fetches an object for me from the repository.

Future<ExerciseEvent?> getLastEvent() => exerciseRepository.getLastEvent();

Here's what the generator returns

 @override
  _i12.Future<_i3.ExerciseEvent?> getLastEvent() => (super.noSuchMethod(
          Invocation.method(#getLastEvent, []),
          returnValue: Future<_i3.ExerciseEvent?>.value(_FakeExerciseEvent()))
      as _i12.Future<_i3.ExerciseEvent?>);

Where here's what I edited from the generator to make work without using the fake.

  @override
  _i11.Future<ExerciseEvent?> getLastEvent() =>
      (super.noSuchMethod(Invocation.method(#getLastEvent, []),
              returnValue: Future<ExerciseEvent?>.value(null))
          as _i11.Future<ExerciseEvent?>);

So because it's null, I can just return null.

But even if ti wasn't nullable, You could still throw a notImplemented exception instead of a fake no?

[cadaniel]

I'll let you decide if further action is needed. Moor has just fixed this making it kinda moot for now

[srawlins]

Your example is intriguing; this easily looks like a bug/shortcoming that we can address in mockito; I'll re-open to fix this.

Thanks for digging it up!!!