Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Commit 32844f3

Browse files
committed
Enable a test that was skipped due to an old browser
Add missing dependency in pubspec Remove unneeded dart_test.yaml file PiperOrigin-RevId: 338101758
1 parent 6e8fc59 commit 32844f3

File tree

3 files changed

+8
-31
lines changed

3 files changed

+8
-31
lines changed

dart_test.yaml

Lines changed: 0 additions & 19 deletions
This file was deleted.

pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ dependencies:
1616

1717
dev_dependencies:
1818
fixnum: '>=0.9.0 <0.11.0'
19+
js: 0.6.3-nullsafety
1920
test: ^1.16.0-nullsafety.4
2021

2122
dependency_overrides:

test/number_format_compact_web_test.dart

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
1-
/// Tests for compact number formatting in pure Dart and in ECMAScript.
2-
///
3-
/// TODO(b/36488375): run all these tests against both implementations to prove
4-
/// consistency when the bug is fixed. Also fix documentation and perhaps
5-
/// merge tests: these tests currently also touch non-compact currency
6-
/// formatting.
7-
8-
/// We use @Tags rather than @TestOn to be able to specify something that can be
9-
/// ignored when using a build system that can't read dart_test.yaml. This
10-
/// depends on https://github.com/tc39/proposal-unified-intl-numberformat.
11-
@Tags(['unifiedNumberFormat'])
12-
1+
@TestOn('browser')
2+
// Tests for compact number formatting in pure Dart and in ECMAScript.
3+
//
4+
// TODO(b/36488375): run all these tests against both implementations to prove
5+
// consistency when the bug is fixed. Also fix documentation and perhaps
6+
// merge tests: these tests currently also touch non-compact currency
7+
// formatting.
138
import 'package:intl/intl.dart' as intl;
149
import 'package:js/js_util.dart' as js;
1510
import 'package:test/test.dart';

0 commit comments

Comments
 (0)