chore: codebase cleanup - remove legacy files and modernize C# syntax (#204)

Co-authored-by: Claude <[email protected]>

Author: tylerkron

Daqifi.Desktop.Common.Test/UnitTest1.cs

@@ -6,10 +6,6 @@
         <assemblyIdentity name="EntityFramework.MappingAPI" publicKeyToken="7ee2e825d201459e" culture="neutral" />
         <bindingRedirect oldVersion="0.0.0.0-6.1.0.9" newVersion="6.1.0.9" />
       </dependentAssembly>
-      <dependentAssembly>
-        <assemblyIdentity name="System.Data.SqlServerCe" publicKeyToken="89845dcd8080cc91" culture="neutral" />
-        <bindingRedirect oldVersion="0.0.0.0-4.0.0.1" newVersion="4.0.0.1" />
-      </dependentAssembly>
       <dependentAssembly>
         <assemblyIdentity name="System.ValueTuple" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
         <bindingRedirect oldVersion="0.0.0.0-4.0.3.0" newVersion="4.0.3.0" />

Daqifi.Desktop.DataModel.Test/UnitTest1.cs

@@ -1,52 +1,50 @@
-using System;
 using System.Collections;
 using System.Globalization;
 using System.Linq;
 using System.Windows.Data;
 
-namespace Daqifi.Desktop.Converters
+namespace Daqifi.Desktop.Converters;
+
+/// <summary>
+/// Converts a list/collection to a comma-separated string
+/// </summary>
+public class ListToStringConverter : IValueConverter
 {
-    /// <summary>
-    /// Converts a list/collection to a comma-separated string
-    /// </summary>
-    public class ListToStringConverter : IValueConverter
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
     {
-        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+        if (value == null)
+            return string.Empty;
+
+        if (value is IEnumerable enumerable)
         {
-            if (value == null)
+            var items = enumerable.Cast<object>().ToList();
+            if (items.Count == 0)
                 return string.Empty;
 
-            if (value is IEnumerable enumerable)
+            // Handle different formatting based on parameter
+            var format = parameter?.ToString() ?? "default";
+            
+            switch (format.ToLower())
             {
-                var items = enumerable.Cast<object>().ToList();
-                if (items.Count == 0)
-                    return string.Empty;
-
-                // Handle different formatting based on parameter
-                var format = parameter?.ToString() ?? "default";
-                
-                switch (format.ToLower())
-                {
-                    case "brackets":
-                        return $"[{string.Join(", ", items)}]";
-                    case "short":
-                        // Limit to first 3 items for short display
-                        var shortItems = items.Take(3).ToList();
-                        var result = string.Join(",", shortItems);
-                        if (items.Count > 3)
-                            result += "...";
-                        return result;
-                    default:
-                        return string.Join(", ", items);
-                }
+                case "brackets":
+                    return $"[{string.Join(", ", items)}]";
+                case "short":
+                    // Limit to first 3 items for short display
+                    var shortItems = items.Take(3).ToList();
+                    var result = string.Join(",", shortItems);
+                    if (items.Count > 3)
+                        result += "...";
+                    return result;
+                default:
+                    return string.Join(", ", items);
             }
-
-            return value.ToString() ?? string.Empty;
         }
 
-        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-        {
-            throw new NotImplementedException("ListToStringConverter does not support ConvertBack");
-        }
+        return value.ToString() ?? string.Empty;
+    }
+
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        throw new NotImplementedException("ListToStringConverter does not support ConvertBack");
     }
 }

Daqifi.Desktop.Test/app.config

@@ -1,27 +1,25 @@
-using System;
 using System.Globalization;
 using System.Windows.Data;
 using System.Windows.Media;
 using OxyPlot;
 using Brushes = System.Windows.Media.Brushes;
 using Color = System.Windows.Media.Color;
 
-namespace Daqifi.Desktop.Converters
+namespace Daqifi.Desktop.Converters;
+
+public class OxyColorToBrushConverter : IValueConverter
 {
-    public class OxyColorToBrushConverter : IValueConverter
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
     {
-        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+        if (value is OxyColor oxyColor)
         {
-            if (value is OxyColor oxyColor)
-            {
-                return new SolidColorBrush(Color.FromArgb(oxyColor.A, oxyColor.R, oxyColor.G, oxyColor.B));
-            }
-            return Brushes.Transparent; // Default or fallback
+            return new SolidColorBrush(Color.FromArgb(oxyColor.A, oxyColor.R, oxyColor.G, oxyColor.B));
         }
+        return Brushes.Transparent; // Default or fallback
+    }
 
-        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-        {
-            throw new NotImplementedException();
-        }
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        throw new NotImplementedException();
     }
 }

Daqifi.Desktop/Converters/ListToStringConverter.cs

@@ -63,7 +63,7 @@
 		<PackageReference Include="MahApps.Metro.IconPacks.Material" Version="5.1.0" />
 		<PackageReference Include="Microsoft.Data.Sqlite" Version="8.0.10" />
 		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.10" />
-		<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.10" />
+		<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.10" />
 		<PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="8.0.10">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>