refactor: delete the unused functions

Author: dancing-ui

core/llm_token_ratelimit/init.go

@@ -18,23 +18,6 @@ import (
 	"fmt"
 )
 
-func initRules() error {
-	cfg := globalConfig.GetConfig()
-	if cfg == nil {
-		return fmt.Errorf("config is nil")
-	}
-
-	if len(cfg.Rules) == 0 {
-		return nil
-	}
-
-	if _, err := LoadRules(cfg.Rules); err != nil {
-		return err
-	}
-
-	return nil
-}
-
 func Init(cfg *Config) error {
 	if globalConfig == nil {
 		return fmt.Errorf("global config is nil")
@@ -55,7 +38,7 @@ func Init(cfg *Config) error {
 	if err := globalRedisClient.Init(cfg.Redis); err != nil {
 		return err
 	}
-	if err := initRules(); err != nil {
+	if _, err := LoadRules(cfg.Rules); err != nil {
 		return err
 	}
 	return nil

core/llm_token_ratelimit/init_test.go

@@ -254,79 +254,6 @@ func TestInit_ConcurrentSafety(t *testing.T) {
 	}
 }
 
-func TestInitRules_ConcurrentSafety(t *testing.T) {
-	// Save original state
-	originalConfig := globalConfig.GetConfig()
-	defer func() {
-		if originalConfig != nil {
-			globalConfig.SetConfig(originalConfig)
-		}
-	}()
-
-	// Set a test config
-	testConfig := &Config{
-		Rules: []*Rule{
-			{
-				ID:       "test-rule-1",
-				Resource: "/api/test",
-				Strategy: FixedWindow,
-				SpecificItems: []*SpecificItem{
-					{
-						Identifier: Identifier{Type: Header, Value: "*"},
-						KeyItems: []*KeyItem{
-							{
-								Key:   "*",
-								Token: Token{Number: 1000, CountStrategy: TotalTokens},
-								Time:  Time{Unit: Second, Value: 60},
-							},
-						},
-					},
-				},
-			},
-		},
-	}
-
-	err := globalConfig.SetConfig(testConfig)
-	require.NoError(t, err)
-
-	const numGoroutines = 30
-	var wg sync.WaitGroup
-	errors := make(chan error, numGoroutines)
-
-	// Concurrent initRules calls
-	for i := 0; i < numGoroutines; i++ {
-		wg.Add(1)
-		go func(id int) {
-			defer wg.Done()
-			if err := initRules(); err != nil {
-				errors <- fmt.Errorf("initRules failed in goroutine %d: %v", id, err)
-			}
-		}(i)
-	}
-
-	// Wait for completion
-	done := make(chan struct{})
-	go func() {
-		wg.Wait()
-		close(done)
-	}()
-
-	select {
-	case <-done:
-		// Success
-	case err := <-errors:
-		t.Fatal(err)
-	case <-time.After(15 * time.Second):
-		t.Fatal("Test timed out")
-	}
-
-	// Check for any remaining errors
-	close(errors)
-	for err := range errors {
-		t.Errorf("Concurrent error: %v", err)
-	}
-}
-
 // Test that concurrent access doesn't cause data corruption
 func TestSafeConfig_DataIntegrity(t *testing.T) {
 	config := &SafeConfig{}
@@ -534,9 +461,6 @@ func TestGlobalConfig_ConcurrentAccess(t *testing.T) {
 					if cfg != nil {
 						_ = cfg.ErrorCode // Basic access
 					}
-				case 2:
-					// Call initRules (which uses globalConfig.GetConfig internally)
-					_ = initRules() // Ignore errors as rules might not be valid without proper setup
 				}
 			}
 		}(i)

core/llm_token_ratelimit/redis_client.go

@@ -152,34 +152,6 @@ func (c *SafeRedisClient) Eval(script string, keys []string, args ...interface{}
 	return c.client.Eval(context.TODO(), script, keys, args...).Result()
 }
 
-func (c *SafeRedisClient) Set(key string, value interface{}, expiration time.Duration) error {
-	if c == nil {
-		return fmt.Errorf("safe redis client is nil")
-	}
-	c.mu.RLock()
-	defer c.mu.RUnlock()
-
-	if c.client == nil {
-		return fmt.Errorf("redis client is not initialized")
-	}
-
-	return c.client.Set(context.TODO(), key, value, expiration).Err()
-}
-
-func (c *SafeRedisClient) Get(key string) (*redis.StringCmd, error) {
-	if c == nil {
-		return nil, fmt.Errorf("safe redis client is nil")
-	}
-	c.mu.RLock()
-	defer c.mu.RUnlock()
-
-	if c.client == nil {
-		return nil, fmt.Errorf("redis client is not initialized")
-	}
-
-	return c.client.Get(context.TODO(), key), nil
-}
-
 func (c *SafeRedisClient) Close() error {
 	if c == nil {
 		return fmt.Errorf("safe redis client is nil")

core/llm_token_ratelimit/rule.go

@@ -32,7 +32,7 @@ func (r *Rule) ResourceName() string {
 	return r.Resource
 }
 
-// TODO: update rule string and tests
+// TODO: update rule string and tests when rule changed
 func (r *Rule) String() string {
 	if r == nil {
 		return "Rule{nil}"