feat: respect blocked tags in briefing requests (#3629)

Co-authored-by: Claude Opus 4.6 <[email protected]>

Author: davidercruz

AGENTS.md

@@ -99,6 +99,7 @@ The migration generator compares entities against the local database schema. Ens
   - Always consult the [Zod 4.x documentation](https://zod.dev) for the latest API
 - When possible, prefer Zod schemas over manual validation as they provide type safety, better error messages, and can be inferred to TypeScript types.
 - **Connect RPC handlers must return typed proto message classes** from `@dailydotdev/schema`, not plain objects. Use `new ResponseType({...})` instead of returning `{...}` directly. **This applies to mock/`isMockEnabled` returns too** — when mocking RPC transport, always use actual proto message class instances, not raw JSON objects.
+- **Never create wrapper types around `@dailydotdev/schema` classes** (e.g., `UserBriefingRequest & { extraField }`) — if a field exists in the proto, use it directly. If it doesn't exist yet, update the schema package first.
   ```typescript
   // BAD: plain object
   return {
@@ -159,6 +160,7 @@ The migration generator compares entities against the local database schema. Ens
 - Mercurius integration testing for GraphQL endpoints
 - Avoid creating multiple overlapping tests for the same scenario; a single test per key scenario is preferred
 - When evaluating response objects (GraphQL, API), prefer `toEqual` and `toMatchObject` over multiple `expect().toBe()` lines
+- **Prefer strict schema assertions over `expect.objectContaining`** — when verifying proto message payloads (e.g., `UserBriefingRequest`), use `new SchemaClass({...})` to assert exact structure. `expect.objectContaining` weakens validation by ignoring extra fields, which defeats schema correctness checks.
 - Avoid redundant test assertions - if an assertion already verifies the value, don't add negative checks that are logically implied (e.g., if `expect(result).toBe('a')` passes, don't also check `expect(result).not.toBe('b')`)
 - When adding/removing persisted entity fields, update affected Jest snapshots in worker/integration tests (for example `toMatchSnapshot` payloads) as part of the same change to avoid CI drift.
 - **Typed worker tests**: Always use the generic type parameter with `expectSuccessfulTypedBackground<'topic-name'>()` for type safety. Use `toChangeObject()` to convert entities to the expected message payload format:

__tests__/workers/brief/userGenerateBrief.ts

@@ -173,6 +173,7 @@ describe('userGenerateBrief worker', () => {
       frequency: BriefingType.Daily,
       model_name: BriefingModel.Default,
       allowed_tags: ['webdev', 'development'],
+      blocked_tags: ['fullstack'],
       seniority_level: 'NOT_ENGINEER',
     });
 
@@ -203,6 +204,7 @@ describe('userGenerateBrief worker', () => {
           frequency: BriefingType.Daily,
           modelName: BriefingModel.Default,
           allowedTags: ['webdev', 'development'],
+          blockedTags: ['fullstack'],
           seniorityLevel: 'NOT_ENGINEER',
         }),
         postId,
@@ -355,6 +357,7 @@ describe('userGenerateBrief worker', () => {
       frequency: BriefingType.Daily,
       model_name: BriefingModel.Default,
       allowed_tags: ['webdev', 'development'],
+      blocked_tags: ['fullstack'],
       seniority_level: 'NOT_ENGINEER',
       recent_briefing: {
         sections: [
@@ -400,6 +403,7 @@ describe('userGenerateBrief worker', () => {
           frequency: BriefingType.Daily,
           modelName: BriefingModel.Default,
           allowedTags: ['webdev', 'development'],
+          blockedTags: ['fullstack'],
           seniorityLevel: 'NOT_ENGINEER',
           recentBriefing: {
             sections: [
@@ -408,7 +412,7 @@ describe('userGenerateBrief worker', () => {
                 items: [
                   {
                     title: 'OpenAI gets a DoD contract, Microsoft gets salty',
-                    body: `OpenAI landed a $200 million contract with the US Department of Defense for AI tools, marking its first direct federal government partnership. This move, reported by The Verge and TechCrunch, signals a shift from OpenAI’s previous stance on military use. It also puts them in direct competition with Microsoft, their main investor, who previously handled government AI contracts through Azure. The tension is real, with OpenAI reportedly considering an antitrust complaint against Microsoft to loosen their grip.`,
+                    body: `OpenAI landed a $200 million contract with the US Department of Defense for AI tools, marking its first direct federal government partnership. This move, reported by The Verge and TechCrunch, signals a shift from OpenAI\u2019s previous stance on military use. It also puts them in direct competition with Microsoft, their main investor, who previously handled government AI contracts through Azure. The tension is real, with OpenAI reportedly considering an antitrust complaint against Microsoft to loosen their grip.`,
                   },
                 ],
               },
@@ -525,6 +529,7 @@ describe('userGenerateBrief worker', () => {
       frequency: BriefingType.Daily,
       model_name: BriefingModel.Default,
       allowed_tags: ['webdev', 'development'],
+      blocked_tags: ['fullstack'],
       seniority_level: 'NOT_ENGINEER',
       recent_briefing: {
         sections: [
@@ -702,6 +707,7 @@ describe('userGenerateBrief worker', () => {
       frequency: BriefingType.Daily,
       model_name: BriefingModel.Default,
       allowed_tags: ['webdev', 'development'],
+      blocked_tags: ['fullstack'],
       seniority_level: 'NOT_ENGINEER',
     });
 
@@ -733,6 +739,7 @@ describe('userGenerateBrief worker', () => {
           frequency: BriefingType.Daily,
           modelName: BriefingModel.Default,
           allowedTags: ['webdev', 'development'],
+          blockedTags: ['fullstack'],
           seniorityLevel: 'NOT_ENGINEER',
         }),
         postId,

package.json

@@ -37,7 +37,7 @@
     "@connectrpc/connect-fastify": "^1.6.1",
     "@connectrpc/connect-node": "^1.6.1",
     "@dailydotdev/graphql-redis-subscriptions": "^2.4.3",
-    "@dailydotdev/schema": "0.2.72",
+    "@dailydotdev/schema": "0.2.73",
     "@dailydotdev/ts-ioredis-pool": "^1.0.2",
     "@fastify/cookie": "^11.0.2",
     "@fastify/cors": "^11.2.0",

pnpm-lock.yaml

@@ -46,12 +46,14 @@ export const getUserConfigForBriefingRequest = async ({
 }: {
   con: EntityManager;
   userId: string;
-}): Promise<Pick<UserBriefingRequest, 'allowedTags' | 'seniorityLevel'>> => {
+}): Promise<
+  Pick<UserBriefingRequest, 'allowedTags' | 'blockedTags' | 'seniorityLevel'>
+> => {
   if (!userId) {
     throw new Error('User id is required');
   }
 
-  const [user, keywords] = await Promise.all([
+  const [user, keywords, blockedKeywords] = await Promise.all([
     con.getRepository(User).findOneOrFail({
       select: ['id', 'experienceLevel'],
       where: {
@@ -69,10 +71,19 @@ export const getUserConfigForBriefingRequest = async ({
         ]),
       },
     }),
+    con.getRepository(ContentPreferenceKeyword).find({
+      select: ['keywordId'],
+      where: {
+        userId: userId,
+        feedId: userId,
+        status: ContentPreferenceStatus.Blocked,
+      },
+    }),
   ]);
 
   return {
     allowedTags: keywords.map((item) => item.keywordId),
+    blockedTags: blockedKeywords.map((item) => item.keywordId),
     seniorityLevel: user.experienceLevel ?? undefined,
   };
 };

src/common/brief.ts

@@ -78,14 +78,17 @@ export class FeedClient implements IFeedClient, IGarmrClient {
     };
   }
 
-  async getUserBrief({
-    userId,
-    frequency,
-    modelName = BriefingModel.Default,
-    allowedTags,
-    seniorityLevel,
-    recentBriefing,
-  }: UserBriefingRequest): Promise<Briefing> {
+  async getUserBrief(request: UserBriefingRequest): Promise<Briefing> {
+    const {
+      userId,
+      frequency,
+      modelName = BriefingModel.Default,
+      allowedTags,
+      blockedTags,
+      seniorityLevel,
+      recentBriefing,
+    } = request;
+
     const result = await this.garmr.execute(() => {
       return fetchParse<JsonValue>(`${this.url}/api/user/briefing`, {
         ...this.fetchOptions,
@@ -95,6 +98,7 @@ export class FeedClient implements IFeedClient, IGarmrClient {
           frequency,
           model_name: modelName,
           allowed_tags: allowedTags,
+          blocked_tags: blockedTags,
           seniority_level: seniorityLevel,
           recent_briefing: recentBriefing
             ? {

src/integrations/feed/clients.ts

@@ -95,6 +95,7 @@ export const userGenerateBriefWorker: TypedWorker<'api.v1.brief-generate'> = {
       );
 
       briefRequest.allowedTags = userConfig.allowedTags;
+      briefRequest.blockedTags = userConfig.blockedTags;
       briefRequest.seniorityLevel = userConfig.seniorityLevel;
 
       const lastBriefPost = await queryReadReplica<Pick<