fix: pass staleCursor from feed service through to GraphQL PageInfo

Add staleCursor support to graphorm.nodesToConnection via an optional
extraPageInfo parameter, threaded through queryPaginated. The feed
resolver extracts staleCursor from the feed service response and passes
it so it reaches the GraphQL PageInfo.

Previously staleCursor was silently dropped because the feed resolver
uses graphorm.queryPaginated (not connectionFromNodes), and
nodesToConnection only included the 4 standard PageInfo fields.

Author: pnvasanth

__tests__/integrations/feed.ts

@@ -10,6 +10,7 @@ import {
   connectionFromNodes,
   feedCursorPageGenerator,
 } from '../../src/schema/common';
+import graphorm from '../../src/graphorm';
 import { MockContext, saveFixtures } from '../helpers';
 import { deleteKeysByPattern } from '../../src/redis';
 import createOrGetConnection from '../../src/db';
@@ -240,6 +241,60 @@ describe('connectionFromNodes with staleCursor', () => {
   });
 });
 
+describe('nodesToConnection with staleCursor', () => {
+  const nodeToCursor = (_node: { id: string }, index: number) =>
+    `cursor-${index}`;
+
+  it('should include staleCursor in pageInfo when extraPageInfo is provided', () => {
+    const nodes = [{ id: '1' }, { id: '2' }];
+    const result = graphorm.nodesToConnection(
+      nodes,
+      nodes.length,
+      () => false,
+      () => true,
+      nodeToCursor,
+      { staleCursor: true },
+    );
+
+    expect(result.pageInfo).toMatchObject({
+      staleCursor: true,
+      hasNextPage: true,
+      hasPreviousPage: false,
+    });
+    expect(result.edges).toHaveLength(2);
+  });
+
+  it('should not include staleCursor when extraPageInfo is not provided', () => {
+    const nodes = [{ id: '1' }, { id: '2' }];
+    const result = graphorm.nodesToConnection(
+      nodes,
+      nodes.length,
+      () => false,
+      () => true,
+      nodeToCursor,
+    );
+
+    expect(result.pageInfo.staleCursor).toBeUndefined();
+  });
+
+  it('should include staleCursor in pageInfo when nodes are empty', () => {
+    const result = graphorm.nodesToConnection(
+      [],
+      0,
+      () => false,
+      () => false,
+      nodeToCursor,
+      { staleCursor: true },
+    );
+
+    expect(result.pageInfo).toMatchObject({
+      staleCursor: true,
+      hasNextPage: false,
+    });
+    expect(result.edges).toHaveLength(0);
+  });
+});
+
 describe('FeedPreferencesConfigGenerator', () => {
   beforeEach(async () => {
     await saveFixtures(con, Source, sourcesFixture);

src/common/feedGenerator.ts

@@ -31,6 +31,7 @@ import { mapArrayToOjbect } from './object';
 import { runInSpan } from '../telemetry';
 import { whereVordrFilter } from './vordr';
 import { baseFeedConfig, type FeedFlagsFilters } from '../integrations/feed';
+import type { FeedResponse } from '../integrations/feed/types';
 import { ContentPreferenceSource } from '../entity/contentPreference/ContentPreferenceSource';
 import { ContentPreferenceKeyword } from '../entity/contentPreference/ContentPreferenceKeyword';
 import {
@@ -556,6 +557,8 @@ export function feedResolver<
           )
         : [];
 
+    const staleCursor = (queryParams as FeedResponse)?.staleCursor;
+
     const result = await runInSpan('feedResolver.queryPaginated', async () =>
       graphorm.queryPaginated<GQLPost>(
         context,
@@ -597,8 +600,10 @@ export function feedResolver<
         (nodes) =>
           pageGenerator.transformNodes?.(page, nodes, queryParams) ?? nodes,
         true,
+        staleCursor ? { staleCursor } : undefined,
       ),
     );
+
     // Sometimes the feed can have a bit less posts than requested due to recent ban or deletion
     if (
       warnOnPartialFirstPage &&

src/graphorm/graphorm.ts

@@ -8,14 +8,18 @@ import {
 } from 'typeorm';
 import { parseResolveInfo, ResolveTree } from 'graphql-parse-resolve-info';
 import { Context } from '../Context';
-import { Connection, Edge } from 'graphql-relay';
+import { Connection, Edge, PageInfo } from 'graphql-relay';
 import { EntityTarget } from 'typeorm/common/EntityTarget';
 import type { GraphqlPayload } from '../routes/public/graphqlExecutor';
 
 export type QueryBuilder = SelectQueryBuilder<any>;
 
 export type GraphORMBuilder = { queryBuilder: QueryBuilder; alias: string };
 
+export type ExtraPageInfo = {
+  staleCursor?: boolean;
+};
+
 export interface GraphORMPagination {
   limit: number;
   hasPreviousPage: (nodeSize: number) => boolean;
@@ -584,6 +588,7 @@ export class GraphORM {
     hasPreviousPage: (nodeSize: number) => boolean,
     hasNextPage: (nodeSize: number) => boolean,
     nodeToCursor: (node: T, index: number) => string,
+    extraPageInfo?: ExtraPageInfo,
   ): Connection<T> {
     if (!nodes.length) {
       return {
@@ -592,7 +597,8 @@ export class GraphORM {
           endCursor: null,
           hasNextPage: hasNextPage(pretransformNodeSize),
           hasPreviousPage: hasPreviousPage(pretransformNodeSize),
-        },
+          ...extraPageInfo,
+        } as PageInfo,
         edges: [],
       };
     }
@@ -608,7 +614,8 @@ export class GraphORM {
         endCursor: edges[edges.length - 1].cursor,
         hasNextPage: hasNextPage(pretransformNodeSize),
         hasPreviousPage: hasPreviousPage(pretransformNodeSize),
-      },
+        ...extraPageInfo,
+      } as PageInfo,
       edges,
     };
   }
@@ -775,6 +782,7 @@ export class GraphORM {
     beforeQuery?: (builder: GraphORMBuilder) => GraphORMBuilder,
     transformNodes?: (nodes: T[]) => T[],
     readReplica?: boolean,
+    extraPageInfo?: ExtraPageInfo,
   ): Promise<Connection<T>> {
     const parsedInfo = parseResolveInfo(resolveInfo) as ResolveTree;
     if (parsedInfo) {
@@ -795,6 +803,7 @@ export class GraphORM {
         hasPreviousPage,
         hasNextPage,
         nodeToCursor,
+        extraPageInfo,
       );
     }
     throw new Error('Resolve info is empty');