Use D: drive as default work-vol

It's measurably faster, so it makes no sense not to use it by default.

Author: gstrauss

README.md

@@ -22,14 +22,14 @@ Parameters
 | ------------------- | -------------------------------------------- | -----------
 | platform            | x86_64                                       | Install the x86 or x86\_64 version of Cygwin.
 | packages            | *none*                                       | List of additional packages to install.
-| install-dir         | C:\cygwin                                    | Installation directory (overrides work-vol)
+| install-dir         | D:\cygwin                                    | Installation directory (overrides work-vol)
 | site                | http://mirrors.kernel.org/sourceware/cygwin/ | Mirror sites to install from, separated by whitespace
 | pubkeys             | *none*                                       | Absolute paths of extra public key files (RFC4880 format), separated by whitespace
 | check-sig           | true                                         | Whether to check the setup.ini signature
 | add-to-path         | true                                         | Whether to add Cygwin's `/bin` directory to the system `PATH`
 | allow-test-packages | false                                        | Consider package versions marked test for installation
 | check-hash          | true                                         | Whether to check the hash of the downloaded Cygwin installer.
-| work-vol            | C:                                           | Volume on which to store setup and packages, and install Cygwin.
+| work-vol            | D:                                           | Volume on which to store setup and packages, and install Cygwin.
 
 Line endings
 ------------

action.yml

@@ -10,8 +10,8 @@ inputs:
     description: Packages to install
     required: false
   install-dir:
-    # by default, install to C:\cygwin rather than the platform dependent
-    # default to make everything simpler
+    # For consistency and simplicity, install to <work-dir>:\cygwin rather
+    # than to the platform dependent default (e.g. <work-dir>:\cygwin64)
     description: Installation directory (overrides work-vol)
     required: false
     default: ''
@@ -40,7 +40,7 @@ inputs:
   work-vol:
     description: Volume on which to store setup and packages, and install Cygwin
     required: false
-    default: 'C:'
+    default: ''
 
 runs:
   using: "composite"
@@ -55,7 +55,17 @@ runs:
           echo "unknown platform $platform"
           exit 1
         }
+
         $vol = '${{ inputs.work-vol }}'
+        # If temporary drive D: doesn't exist in the VM, fallback to C:
+        if ("$vol" -eq '') {
+          if (Test-Path -LiteralPath 'D:\') {
+            $vol = 'D:'
+            } else {
+            $vol = 'C:'
+            }
+        }
+
         $setupExe = "$vol\setup.exe"
         $setupFileName = "setup-$platform.exe"
         Invoke-WebRequest "https://cygwin.com/$setupFileName" -OutFile $setupExe
@@ -146,6 +156,12 @@ runs:
         # PowerShell wait for it to exit
         & $setupExe $args | Out-Default
 
+        if ('${{ inputs.work-vol }}' -eq '' -and '${{ inputs.install-dir }}' -eq '') {
+          # Create a symlink for compatibility with previous versions of this
+          # action, just in case something relies upon C:\cygwin existing
+          cmd /c mklink /d C:\cygwin $installDir
+        }
+
         if ('${{ inputs.add-to-path }}' -eq 'true') {
           echo "$installDir\bin" >> $env:GITHUB_PATH
         }